Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPLIT] OrangeFox support #218

Merged
merged 4 commits into from
Aug 4, 2023
Merged

[SPLIT] OrangeFox support #218

merged 4 commits into from
Aug 4, 2023

Conversation

anon1892
Copy link
Member

@anon1892 anon1892 commented Aug 1, 2023

Some modifications to the code, so OrangeFox recovery can be supported (especially useful for Xiaomi devices)

Work started in #188

It works, but I don't like the fix line 267 of tooling.py

This was referenced Aug 1, 2023
Merged
Merged
Merged
Merged
Merged
Closed
MagicLike
MagicLike reviewed Aug 1, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@MagicLike MagicLike mentioned this pull request Aug 1, 2023
Closed
@tsterbak
Copy link
Member

tsterbak commented Aug 2, 2023

I'm thinking about how to best proceed with these PRs.
I guess, I prepare a branch for release 0.5.0 and merge them one by one. This way I can make modifications to the code and you could test it with your devices. The only downside would be, that you would need to send a new PR to make changes. How does that sound for you?

@anon1892
Copy link
Member Author

anon1892 commented Aug 2, 2023

Yes, as you wish! Now I'm a pro at making PR, lol

This was referenced Aug 2, 2023
Merged
Open
@tsterbak tsterbak added this to the Release Beta-Version 0.5.0 milestone Aug 4, 2023
@tsterbak tsterbak added the enhancement New feature or request label Aug 4, 2023
@tsterbak tsterbak changed the base branch from dev to dev-0.5.0 August 4, 2023 07:07
@tsterbak tsterbak merged commit a4bf0a0 into openandroidinstaller-dev:dev-0.5.0 Aug 4, 2023
@tsterbak
Copy link
Member

tsterbak commented Aug 4, 2023 •
edited
Loading

@anon1892 I have a few questions going forward:

  • Ofox recommends booting the recovery (at least for A/B-partitioned devices). I would also prefer that. What do you think? (source: can-i-run-fastboot-boot-to-boot-an-orangefox-img-file) So the process seems to be dangerous here...
  • I would prefer to expect official OrangeFox names for the recoveries (like OrangeFox-lavender-stable@R11.1_5_A12.zip), why would it be named recovery.img?

@anon1892
Copy link
Member Author

anon1892 commented Aug 4, 2023

For non a/b devices, like lavender #222, I never do that (and not asked in LineageOS installation process)
I also created a function to boot the recovery, see rosemary #225 (I follow LineageOS instructions)

Yes, we can also use the zip file, to check if it's the right OFox version. But after that, we need unzip it and only flash recovery.img file on it. It require more code. But can be a good option, because we will need to distinguish OFox with LOS recovery, which both are named recovery.img

@anon1892 anon1892 mentioned this pull request Aug 4, 2023
Merged
@tsterbak
Copy link
Member

tsterbak commented Aug 4, 2023

For non a/b devices, like lavender #222, I never do that (and not asked in LineageOS installation process)
I also created a function to boot the recovery, see rosemary #225 (I follow LineageOS instructions)

I see :)

Yes, we can also use the zip file, to check if it's the right OFox version. But after that, we need unzip it and only flash recovery.img file on it. It require more code. But can be a good option, because we will need to distinguish OFox with LOS recovery, which both are named recovery.img

Ah sorry, I missed, that it is a zip file...

@anon1892 anon1892 mentioned this pull request Aug 4, 2023
Merged
@anon1892 anon1892 deleted the For_New_PR branch August 12, 2023 09:18
@anon1892 anon1892 mentioned this pull request Aug 12, 2023
Merged
3 tasks
tsterbak added a commit that referenced this pull request Aug 16, 2023
@tsterbak
[SPLIT] Add support for Mi439 (Redmi 7A & co.) (#226)
cceae91 
Work started and tested in #188 : working

Requirements : 
- #218 for OrangeFox support (especially `fastboot_flash_recovery` and
`fastboot_reboot_recovery`)
- #220 for additional partitions support
- #221 for device specific notes (optional)
@anon1892 anon1892 mentioned this pull request Sep 20, 2023
Open
tsterbak added a commit that referenced this pull request Sep 27, 2023
@tsterbak
[SPLIT] Add support for lavender (Xiaomi Redmi Note 7) (#222)
55b4ab5 
Work started and tested in #188 : works fine

Requirements : 
- #218 for OrangeFox support (especially `fastboot_flash_recovery` and
`fastboot_reboot_recovery`
- #221 for device specific notes (optional)
tsterbak added a commit that referenced this pull request Sep 27, 2023
@tsterbak
[SPLIT] Add support for ginkgo (Xiaomi Redmi Note 8 / 8T) (#223)
89a17ba 
Work started in #188 

Untested but should work (same steps as #222 )

Requirements : 
- #218 for OrangeFox support (especially `fastboot_flash_recovery` and
`fastboot_reboot_recovery`
- #221 for device specific notes (optional)
tsterbak added a commit that referenced this pull request Sep 27, 2023
@tsterbak
[SPLIT] Add support for garden (Xiaomi Redmi 9A & co.) (#224)
29285c3 
Work started and tested in #188 : working

Requirements : 
- #218 for OrangeFox support (especially `fastboot_flash_recovery` and
`fastboot_reboot_recovery`
- #221 for device specific notes (optional)
tsterbak added a commit that referenced this pull request Sep 27, 2023
@tsterbak
[SPLIT] Add support for rosemary (Xiaomi Redmi Note 10S & co.) (#225)
9819a3c 
Work started in #188 

Untested but should work

Requirements : 
- #218 for OrangeFox support (optional)
- #221 for device specific notes (optional)
tsterbak added a commit that referenced this pull request Sep 27, 2023
@tsterbak
Add support for miatoll (Xiaomi Redmi Note 9 Pro / 9S ... Poco M2 Pro) (
5f79942 
#228)

Related to issue #85. Not tested !

Requirements : 
- #218 for OrangeFox support (especially `fastboot_flash_recovery` and
`fastboot_reboot_recovery`
- #221 for device specific notes (optional)

Actually, the best way of testing may be using the `main` branch of [my
fork](https://github.com/anon1892/oai/tree/main), since it need 3 PR to
work as is.
tsterbak added a commit that referenced this pull request Sep 27, 2023
@tsterbak
Add support for davinci (Xiaomi Mi 9T / Redmi K20) (#234)
3cf8b1d 
Related to issue #232.  Not tested !

Requirements : 
- #218 for OrangeFox support (especially `fastboot_flash_recovery` and
`fastboot_reboot_recovery`
- #221 for device specific notes (optional)

@Chronos093
tsterbak added a commit that referenced this pull request Sep 27, 2023
@tsterbak
Add support for raphael (Xiaomi Mi 9T Pro / Redmi K20 Pro) (#235)
333a6b0 
Untested ! Asked in #212. @alkman1982 do you want to help us by testing
it?

Requirements : 
- #218 for OrangeFox support (especially `fastboot_flash_recovery` and
`fastboot_reboot_recovery`)
- #220 for additional partitions support
- #221 for device specific notes (optional)

I used this :
https://forum.xda-developers.com/t/rom-t-unofficial-lineageos-20-0-for-redmi-k20-pro-mi-9t-pro-raphael.4464937/
@SirRGB SirRGB mentioned this pull request Nov 21, 2023
Merged
@anon1892 anon1892 mentioned this pull request Feb 7, 2024
Open
@tsterbak tsterbak mentioned this pull request Feb 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MagicLike MagicLike MagicLike left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Release Beta-Version 0.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anon1892 @tsterbak @MagicLike