-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPLIT] Add dtbo, vbmeta, super_empty flashing #220
Conversation
Could we detect if it is a Android 13 based ROM? It seems to be necessary for most devices with Android 13 based ROMs... |
Yes, we can! The same way you detect if user selected image is compatible with the phone. See f464396 |
Great! So we could enable the flashing of these additional partitions only for images based on Android 13 or higher (if required at all)? |
As far I remember, it's not needed before A13, but not sure. But seems to be implemented since Android 10 : |
This PR is based on #220 (by @anon1892) and aims to integrate the code in the Installer. - Include the commands `fastboot_flash_recovery` and `fastboot_reboot_recovery` (thanks to @anon1892) - Add support for Mi439 (Redmi 7A & co.) (thanks to @anon1892) - Display device specific notes at the image selection step (thanks to @anon1892) Other fixes & additions: - Display the scroll bar by default if scrolling is necessary - An info text box for additional images Todo: - [x] When the "custom recovery already flashed" button is selected, user should not have to select recovery file, as in this PR for now. - [x] User should be able not to select additional partitions, even on Android 13 (maybe add a button like "custom recovery already flashed". - [x] When recovery flashing is disabled, `adb reboot recovery` is not performed. Fix that.
Untested ! Asked in #212. @alkman1982 do you want to help us by testing it? Requirements : - #218 for OrangeFox support (especially `fastboot_flash_recovery` and `fastboot_reboot_recovery`) - #220 for additional partitions support - #221 for device specific notes (optional) I used this : https://forum.xda-developers.com/t/rom-t-unofficial-lineageos-20-0-for-redmi-k20-pro-mi-9t-pro-raphael.4464937/
Allow user to flash dtbo, vbmeta and super_empty if needed :
Buttons shows off only if asked in device config file, and are optional, because it depends on the ROM (especially android version wanted)
Work started and tested in #188 but not in this PR alone (it's a copy and paste, so if I didn't forget something, it will work)