Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPLIT] Add dtbo, vbmeta, super_empty flashing #220

Closed
wants to merge 2 commits into from

Conversation

anon1892
Copy link
Member

@anon1892 anon1892 commented Aug 1, 2023

Allow user to flash dtbo, vbmeta and super_empty if needed :
Buttons shows off only if asked in device config file, and are optional, because it depends on the ROM (especially android version wanted)

Work started and tested in #188 but not in this PR alone (it's a copy and paste, so if I didn't forget something, it will work)

@tsterbak tsterbak added this to the Release Beta-Version 0.5.0 milestone Aug 4, 2023
@tsterbak tsterbak added the enhancement New feature or request label Aug 4, 2023
@tsterbak tsterbak changed the base branch from main to dev-0.5.0 August 4, 2023 07:51
@tsterbak tsterbak changed the base branch from dev-0.5.0 to dev August 4, 2023 09:06
@tsterbak
Copy link
Member

tsterbak commented Aug 4, 2023

Could we detect if it is a Android 13 based ROM? It seems to be necessary for most devices with Android 13 based ROMs...
Otherwise I'm wondering how we get this user friendly and explain why and when it is needed.
But it should have some priority, since for a lot of Android 13 based ROMs it is indeed required...

@anon1892
Copy link
Member Author

anon1892 commented Aug 4, 2023

Yes, we can! The same way you detect if user selected image is compatible with the phone. See f464396

@tsterbak
Copy link
Member

tsterbak commented Aug 4, 2023

Yes, we can! The same way you detect if user selected image is compatible with the phone.

Great! So we could enable the flashing of these additional partitions only for images based on Android 13 or higher (if required at all)?
I'm trying to remember if there are devices that need it for older android versions, can you recall? 🤔

@anon1892
Copy link
Member Author

anon1892 commented Aug 4, 2023

As far I remember, it's not needed before A13, but not sure.

But seems to be implemented since Android 10 :
https://source.android.com/docs/core/ota/dynamic_partitions/implement
https://android.googlesource.com/platform/system/core.git/+/7c84b9fea2937c467adb257e27a9cac0ce40f24d

@tsterbak tsterbak mentioned this pull request Aug 8, 2023
3 tasks
tsterbak added a commit that referenced this pull request Aug 16, 2023
Work started and tested in #188 : working

Requirements : 
- #218 for OrangeFox support (especially `fastboot_flash_recovery` and
`fastboot_reboot_recovery`)
- #220 for additional partitions support
- #221 for device specific notes (optional)
@tsterbak tsterbak closed this Aug 22, 2023
tsterbak added a commit that referenced this pull request Sep 26, 2023
This PR is based on #220 (by @anon1892) and aims to integrate the code
in the Installer.

- Include the commands `fastboot_flash_recovery` and
`fastboot_reboot_recovery` (thanks to @anon1892)
- Add support for Mi439 (Redmi 7A & co.) (thanks to @anon1892)
- Display device specific notes at the image selection step (thanks to
@anon1892)

Other fixes & additions:
- Display the scroll bar by default if scrolling is necessary
- An info text box for additional images

Todo:
- [x] When the "custom recovery already flashed" button is selected,
user should not have to select recovery file, as in this PR for now.
- [x] User should be able not to select additional partitions, even on
Android 13 (maybe add a button like "custom recovery already flashed".
- [x] When recovery flashing is disabled, `adb reboot recovery` is not
performed. Fix that.
tsterbak added a commit that referenced this pull request Sep 27, 2023
Untested ! Asked in #212. @alkman1982 do you want to help us by testing
it?

Requirements : 
- #218 for OrangeFox support (especially `fastboot_flash_recovery` and
`fastboot_reboot_recovery`)
- #220 for additional partitions support
- #221 for device specific notes (optional)

I used this :
https://forum.xda-developers.com/t/rom-t-unofficial-lineageos-20-0-for-redmi-k20-pro-mi-9t-pro-raphael.4464937/
@anon1892 anon1892 deleted the dtbo branch October 3, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants