Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add mi439 twrp name #363

Merged
merged 1 commit into from
Nov 22, 2023
Merged

add mi439 twrp name #363

merged 1 commit into from
Nov 22, 2023

Conversation

SirRGB
Copy link
Contributor

@SirRGB SirRGB commented Nov 19, 2023 •
edited
Loading

Should partially fix #352

@SirRGB
Copy link
Contributor Author

SirRGB commented Nov 20, 2023 •
edited
Loading

Might need to edit the config to not recommend ofox...
Or just drop notes?

Edit:
Was there any reason other than availability to choose ofox over twrp? Alioth has twrp officially available too btw.

@anon1892
Copy link
Member

At the beginning, I started to support Xiaomi devices in OAI with OrangeFox, but OFox addition to OAI is delayed to v0.6 or maybe more. For some devices, only OFox is available (it was created at the beginning for Xiaomi devices), and it's more user-friendly I think.

But it can be removed for now, you're right.

@SirRGB
Copy link
Contributor Author

SirRGB commented Nov 21, 2023 •
edited
Loading

Might be more userfriendly to point the user to a direct twrp download link for now. U can change it once ofox is fully supported ig.

So you already did this, but I assume it doesnt have alias support?
#218

@anon1892
Copy link
Member

What do you mean by alias support?

@SirRGB
Copy link
Contributor Author

SirRGB commented Nov 21, 2023

"twrp-link: mi439"
Should create a valid twrp download link in the installer iirc.
I tought ofox for mi439 was official too.

@SirRGB
add mi439 twrp name
54c62a7 
* capitalization matters
* changes untested
* partially fixes openandroidinstaller-dev#352
@tsterbak tsterbak added the enhancement New feature or request label Nov 22, 2023
@tsterbak tsterbak merged commit 80aa7db into openandroidinstaller-dev:dev Nov 22, 2023
@SirRGB SirRGB deleted the mi439 branch November 23, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Release Beta-Version 0.5.2 - New Year...
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SirRGB @anon1892 @tsterbak