Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switched from flashing to booting TWRP #111

Merged

Conversation

MagicLike
Copy link
Member

OAI now only boots into TWRP instead of flashing and overwriting the existing recovery, which can cause problems with the bootloader not being able to communicate with the recovery.

related to #98 (comment)

@MagicLike MagicLike mentioned this pull request Mar 12, 2023
@MagicLike MagicLike marked this pull request as draft March 12, 2023 17:44
@tsterbak
Copy link
Member

Awesome! I'll test that later and then it should be easy to merge :)

@tsterbak tsterbak self-requested a review March 12, 2023 18:08
@tsterbak tsterbak added the enhancement New feature or request label Mar 12, 2023
@tsterbak tsterbak added this to the Release Beta 0.4.2 milestone Mar 12, 2023
@MagicLike
Copy link
Member Author

Awesome! I'll test that later and then it should be easy to merge :)

I am currently making further changes - renaming the variables, so it is one change and not a little hack 😁

@MagicLike MagicLike marked this pull request as ready for review March 12, 2023 19:53
@MagicLike
Copy link
Member Author

@tsterbak I think I got everything... Oh and one thing: Please merge this PR before my others, because this implements stuff that e.g. #98 now relies on.

@tsterbak tsterbak changed the base branch from dev to release-0.4.2-beta March 24, 2023 17:21
@tsterbak tsterbak merged commit ecd5019 into openandroidinstaller-dev:release-0.4.2-beta Mar 24, 2023
@MagicLike MagicLike deleted the boot-twrp branch March 27, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants