-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Samsung S4 mini (serranolte) #134
Conversation
Looks good! :) Could you add the device also to the README? |
Do you think it would also be save to support other S4 mini variants with this config? |
Readme for serranoltexx added , I'm not sure about 3G variants , we can test and add them later on |
@tsterbak Are two configs for the same device codes necessary? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the trailing slash at the end of the wiki link. All the others will be removed when #129 gets merged...
I guess, having only the @freechelmi do you think this is possible? Then I would resolve the conflict in the readme and merge it. :) |
Done , Yes if you can resolve the conflict :-) |
One thing: please remove the trailing slash as stated in my review. Would it also be possible to move every text of |
serranolte and serranoltexx supported