Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Samsung S4 mini (serranolte) #134

Merged
merged 7 commits into from
Apr 8, 2023

Conversation

freechelmi
Copy link
Contributor

serranolte and serranoltexx supported

@tsterbak tsterbak added the device Request to add or improve a specific device. label Mar 31, 2023
@tsterbak tsterbak added this to the Release Beta 0.4.3 milestone Mar 31, 2023
@tsterbak
Copy link
Member

Looks good! :) Could you add the device also to the README?

@tsterbak
Copy link
Member

Do you think it would also be save to support other S4 mini variants with this config?
For example: https://wiki.lineageos.org/devices/serrano3gxx/ or https://wiki.lineageos.org/devices/serranodsdd/

@freechelmi
Copy link
Contributor Author

Readme for serranoltexx added , I'm not sure about 3G variants , we can test and add them later on

@MagicLike
Copy link
Member

@tsterbak Are two configs for the same device codes necessary?

Copy link
Member

@MagicLike MagicLike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the trailing slash at the end of the wiki link. All the others will be removed when #129 gets merged...

@tsterbak tsterbak changed the base branch from main to dev April 3, 2023 13:14
@tsterbak
Copy link
Member

tsterbak commented Apr 3, 2023

@tsterbak Are two configs for the same device codes necessary?

I guess, having only the serranoltexx config with support for both codes should be fine. If possible only one should exist.

@freechelmi do you think this is possible? Then I would resolve the conflict in the readme and merge it. :)

@freechelmi
Copy link
Contributor Author

Done , Yes if you can resolve the conflict :-)

@MagicLike
Copy link
Member

Done , Yes if you can resolve the conflict :-)

One thing: please remove the trailing slash as stated in my review. Would it also be possible to move every text of content into its own line using the > as shown in line 13 of your config to ensure consistency?

@tsterbak tsterbak merged commit 9dec6ea into openandroidinstaller-dev:dev Apr 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
device Request to add or improve a specific device.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants