Support for Samsung Galaxy Grand Prime VE #140

MagicLike · 2023-04-15T14:23:35Z

Added a config for the Samsung Galaxy Grand Prime VE (grandprimevelte), but I was not able to test it yet, as the device is not officially supported by LineageOS.

Added grandprimevelte to the list, but marked it as `untested`.

tsterbak · 2023-04-15T14:28:02Z

Great! :)

You could test with

MagicLike · 2023-04-15T15:31:39Z

Great! :)

You could test with

* https://forum.xda-developers.com/t/lineageos-13-0-for-grand-prime-velte-sm-g531f.3874411/

* https://eu.dl.twrp.me/grandprimevelte/

Hmmm, OAI / adb gets stuck after executing the adb wait-for-recovery command in the Install OS view. I already looked at the log and there is nothing suspicious or unusual... TWRP booted completely fine and I can interact with it via touch...
Maybe a timing issue (again)?

tsterbak · 2023-04-15T16:15:30Z

Hmmm, OAI / adb gets stuck after executing the adb wait-for-recovery command in the Install OS view. I already looked at the log and there is nothing suspicious or unusual... TWRP booted completely fine and I can interact with it via touch...
Maybe a timing issue (again)?

Does the device to adb wait-for-recovery (or shows up for adb devices) run from the terminal? 🤔 If not, can you try running adb kill-server and adb start-server and try again?

MagicLike · 2023-04-15T16:50:50Z

Does the device to adb wait-for-recovery (or shows up for adb devices) run from the terminal? thinking If not, can you try running adb kill-server and adb start-server and try again?

Yes it shows up for adb devices and adb kill-server gets OAI unstuck, but then it only wipes the cache and userdata partitions and does not install Lineage OS.

Log for install view:

2023-04-15 18:34:25.177 | INFO     | views.install_view:build:129 - Starting installation.
2023-04-15 18:34:26.388 | INFO     | views.install_view:check_advanced_switch:63 - Enable advanced output.
2023-04-15 18:34:33.764 | INFO     | tooling:adb_twrp_wipe_and_install:204 - Wipe and format data with twrp, then install os image.
2023-04-15 18:34:33.765 | INFO     | tooling:logging:88 - Wait for recovery - Paramters: {}
2023-04-15 18:34:33.766 | INFO     | tooling:run_command:59 - Run command: ['/*/openandroidinstaller/openandroidinstaller/bin/adb', 'wait-for-recovery']
2023-04-15 18:34:39.602 | INFO     | tooling:run_command:73 - error: protocol fault (couldn't read status): Success
2023-04-15 18:34:39.604 | ERROR    | tooling:logging:91 - Wait for recovery Failed!
2023-04-15 18:34:39.605 | INFO     | tooling:logging:88 - Perform a factory reset with adb and twrp. - Paramters: {}
2023-04-15 18:34:39.606 | INFO     | tooling:run_command:59 - Run command: ['/*/openandroidinstaller/openandroidinstaller/bin/adb', 'shell', 'twrp', 'format', 'data']
2023-04-15 18:34:39.622 | INFO     | tooling:run_command:73 - adb: protocol fault (couldn't read status): Connection reset by peer
2023-04-15 18:34:39.624 | ERROR    | tooling:logging:91 - Perform a factory reset with adb and twrp. Failed!
2023-04-15 18:34:40.626 | INFO     | tooling:logging:88 - Wipe the selected partition with adb and twrp. - Paramters: {'bin_path': PosixPath('/*/openandroidinstaller/openandroidinstaller/bin'), 'partition': 'cache'}
2023-04-15 18:34:40.628 | INFO     | tooling:run_command:59 - Run command: ['/*/openandroidinstaller/openandroidinstaller/bin/adb', 'shell', 'twrp', 'wipe', 'cache']
2023-04-15 18:34:40.632 | INFO     | tooling:run_command:73 - * daemon not running; starting now at tcp:5037
2023-04-15 18:34:41.915 | INFO     | tooling:run_command:73 - * daemon started successfully
2023-04-15 18:34:41.916 | INFO     | tooling:run_command:73 - adb: no devices/emulators found
2023-04-15 18:34:41.917 | ERROR    | tooling:logging:91 - Wipe the selected partition with adb and twrp. Failed!
2023-04-15 18:34:42.918 | INFO     | tooling:logging:88 - Wipe the selected partition with adb and twrp. - Paramters: {'bin_path': PosixPath('/*/openandroidinstaller/openandroidinstaller/bin'), 'partition': 'system'}
2023-04-15 18:34:42.920 | INFO     | tooling:run_command:59 - Run command: ['/*/openandroidinstaller/openandroidinstaller/bin/adb', 'shell', 'twrp', 'wipe', 'system']
2023-04-15 18:34:42.926 | INFO     | tooling:run_command:73 - adb: no devices/emulators found
2023-04-15 18:34:42.928 | ERROR    | tooling:logging:91 - Wipe the selected partition with adb and twrp. Failed!
2023-04-15 18:34:43.929 | INFO     | tooling:adb_twrp_wipe_and_install:220 - Wiping is done, now activate sideload.
2023-04-15 18:34:43.930 | INFO     | tooling:logging:88 - Activate sideloading in TWRP. - Paramters: {'bin_path': PosixPath('/*/openandroidinstaller/openandroidinstaller/bin')}
2023-04-15 18:34:43.932 | INFO     | tooling:run_command:59 - Run command: ['/*/openandroidinstaller/openandroidinstaller/bin/adb', 'shell', 'twrp', 'sideload']
2023-04-15 18:34:44.382 | INFO     | tooling:logging:88 - Wait for sideload - Paramters: {'bin_path': PosixPath('/*/openandroidinstaller/openandroidinstaller/bin')}
2023-04-15 18:34:44.384 | INFO     | tooling:run_command:59 - Run command: ['/*/GitHub/openandroidinstaller/openandroidinstaller/bin/adb', 'wait-for-sideload']
2023-04-15 18:34:45.892 | INFO     | tooling:adb_twrp_wipe_and_install:224 - Sideload and install os image.
2023-04-15 18:34:45.892 | INFO     | tooling:logging:88 - Sideload the target to device with adb. - Paramters: {'bin_path': PosixPath('/*/openandroidinstaller/openandroidinstaller/bin'), 'target': '/*/lineage-13.0-20190515-UNOFFICIAL-FOSS_AUDIO-grandprimevelte.zip'}
2023-04-15 18:34:45.893 | INFO     | tooling:run_command:59 - Run command: ['/*/openandroidinstaller/openandroidinstaller/bin/adb', 'sideload']
2023-04-15 18:34:45.942 | INFO     | tooling:run_command:73 - 
2023-04-15 18:34:45.943 | INFO     | tooling:run_command:73 - Total xfer: 0.00x
2023-04-15 18:34:52.951 | INFO     | tooling:run_command:59 - Run command: ['/*/openandroidinstaller/openandroidinstaller/bin/adb', 'shell', 'twrp', 'wipe', 'dalvik']
2023-04-15 18:34:53.433 | INFO     | tooling:run_command:73 - -- Wiping Dalvik Cache...
2023-04-15 18:34:53.435 | INFO     | tooling:run_command:73 - 
2023-04-15 18:34:53.440 | INFO     | tooling:run_command:73 - Cleaned: /data/dalvik-cache...
2023-04-15 18:34:53.442 | INFO     | tooling:run_command:73 - -- Dalvik Cache Directories Wipe Complete!
2023-04-15 18:34:53.443 | INFO     | tooling:run_command:73 - -- Dalvik Cache Wipe Complete!
2023-04-15 18:34:53.444 | INFO     | tooling:run_command:73 - Done processing script file
2023-04-15 18:34:56.448 | INFO     | tooling:run_command:59 - Run command: ['/*/openandroidinstaller/openandroidinstaller/bin/adb', 'shell', 'twrp', 'wipe', 'cache']
2023-04-15 18:34:56.498 | INFO     | tooling:run_command:73 - -- Wiping Cache Partition...
2023-04-15 18:34:56.526 | INFO     | tooling:run_command:73 - Formatting Cache using make_ext4fs function.
2023-04-15 18:34:56.923 | INFO     | tooling:run_command:73 - -- Cache Partition Wipe Complete!
2023-04-15 18:34:56.925 | INFO     | tooling:run_command:73 - Done processing script file
2023-04-15 18:35:06.935 | INFO     | tooling:logging:88 - Rebooting device with adb. - Paramters: {'bin_path': PosixPath('/*/openandroidinstaller/openandroidinstaller/bin')}
2023-04-15 18:35:06.937 | INFO     | tooling:run_command:59 - Run command: ['/*/openandroidinstaller/openandroidinstaller/bin/adb', 'reboot']
2023-04-15 18:35:14.870 | SUCCESS  | views.install_view:run_install:213 - Installation process was successful. Allow to continue.
2023-04-15 18:38:25.176 | INFO     | __main__:to_next_view:184 - Confirmed and moved to next step.
2023-04-15 18:38:26.314 | SUCCESS  | views.success_view:close_window:39 - Success! Close the window.

tsterbak · 2023-04-15T17:29:55Z

Yes it shows up for adb devices and adb kill-server gets OAI unstuck, but then it only wipes the cache and userdata partitions and does not install Lineage OS.

Curious issue... 🤔 I had something similar after trying too many things with adb and fastboot. I was already worried my device/usb-ports/cables are broken, but a PC system reboot fixed that issue. That also seems to be a solution for some people with this issue online (for example XDA).

MagicLike · 2023-04-15T17:31:41Z

Yes it shows up for adb devices and adb kill-server gets OAI unstuck, but then it only wipes the cache and userdata partitions and does not install Lineage OS.

Curious issue... thinking I had something similar after trying too many things with adb and fastboot. I was already worried my device/usb-ports/cables are broken, but a PC system reboot fixed that issue. That also seems to be a solution for some people with this issue online (for example XDA).

I will try a reboot later and maybe switching the port...

MagicLike · 2023-04-15T18:05:49Z

Yes it shows up for adb devices and adb kill-server gets OAI unstuck, but then it only wipes the cache and userdata partitions and does not install Lineage OS.

Curious issue... thinking I had something similar after trying too many things with adb and fastboot. I was already worried my device/usb-ports/cables are broken, but a PC system reboot fixed that issue. That also seems to be a solution for some people with this issue online (for example XDA).

I will try a reboot later and maybe switching the port...

Ok, I tried it - nothing changes...

MagicLike · 2023-04-15T18:20:04Z

Ohhh I think I know why it fails - TWRP 2.8.7.0 does not know e.g. the command format, etc.

MagicLike · 2023-04-15T18:22:02Z

~~Also another thing I have spotted: When booting into recovery and the Samsung logo is shown, there is a red Message on to which says Recovery is not Seandroid enforcing.~~

This only appears on TWRP 2.8.7.0 - I force-flashed a new unofficial version manually.

MagicLike · 2023-04-15T18:36:00Z

I acquired a newer unofficial version of TWRP, but OAI won't let me flash it. Is there an option to bypass this block?
Or maybe make an exception for this particular file...

tsterbak · 2023-04-15T19:58:15Z

I acquired a newer unofficial version of TWRP, but OAI won't let me flash it. Is there an option to bypass this block?
Or maybe make an exception for this particular file...

The very basic check on the recovery compatibility with the device is performed by looking for the device code and "twrp" in the file name. So if your TWRP image follows this convention it should let it flash it.

MagicLike · 2023-04-15T21:06:31Z

I acquired a newer unofficial version of TWRP, but OAI won't let me flash it. Is there an option to bypass this block?
Or maybe make an exception for this particular file...

The very basic check on the recovery compatibility with the device is performed by looking for the device code and "twrp" in the file name. So if your TWRP image follows this convention it should let it flash it.

Ok, that worked, but adb shell twrp format data does still not get recognised by TWRP 3.1.1.0 (The unofficial version I found on XDA)... Would it be possible to make an exception when this device is detected to execute adb shell twrp wipe data instead of the format command? Or is there something else I could do?

MagicLike · 2023-04-16T08:28:52Z

@tsterbak Is there a variable in which the current device is stored?

tsterbak · 2023-04-16T09:30:16Z

Ok, that worked, but adb shell twrp format data does still not get recognised by TWRP 3.1.1.0 (The unofficial version I found on XDA)... Would it be possible to make an exception when this device is detected to execute adb shell twrp wipe data instead of the format command? Or is there something else I could do?

You could try to replace format data by wipe data in this function here (https://github.com/openandroidinstaller-dev/openandroidinstaller/blob/dev/openandroidinstaller/tooling.py#L181) and test if it works. If it does, I can probably put that in properly.

tsterbak · 2023-04-16T09:31:25Z

@tsterbak Is there a variable in which the current device is stored?

In the views you can access it by self.state.config.device_code.

tsterbak · 2023-04-16T09:34:54Z

Maybe, there should be a warning somewhere in general, that there might be issues with old twrp versions possibly not supporting all features.

MagicLike · 2023-04-16T10:40:04Z

Ok, that worked, but adb shell twrp format data does still not get recognised by TWRP 3.1.1.0 (The unofficial version I found on XDA)... Would it be possible to make an exception when this device is detected to execute adb shell twrp wipe data instead of the format command? Or is there something else I could do?

You could try to replace format data by wipe data in this function here (https://github.com/openandroidinstaller-dev/openandroidinstaller/blob/dev/openandroidinstaller/tooling.py#L181) and test if it works. If it does, I can probably put that in properly.

Ok, yeah with wipe instead of format it totally works... No errors so far.

MagicLike · 2023-04-16T10:58:59Z

If it does, I can probably put that in properly.

I tried to do it myself, but I only get NameError: name 'self' is not defined... ^^

My changes:

def __init__(self):
    self.state.config.device_code = device_code

    if self.state.config.device_code==grandprimevelte: 
        for line in run_command("adb shell twrp wipe data", bin_path):
            yield line
    else:
        for line in run_command("adb shell twrp format data", bin_path):
            yield line

tsterbak · 2023-04-16T12:14:45Z

def __init__(self):
      self.state.config.device_code = device_code

Is not necessary, and I also don't know where this function is going?

    if self.state.config.device_code==grandprimevelte: 
        for line in run_command("adb shell twrp wipe data", bin_path):
            yield line
    else:
        for line in run_command("adb shell twrp format data", bin_path):
            yield line

I assume this is in the tooling module. There you have no access to the components of the views and the state since I try to keep the direct device interactions as separate from the rest as I could manage.
What you could try, is to pass a use_wipe boolean flag to the function to trigger this change.
Or, just let the format fail, catch that and retry with wipe data. If this doesn't break adb, I think I would prefer this.

MagicLike · 2023-04-16T12:45:12Z

def __init__(self):
      self.state.config.device_code = device_code
Is not necessary, and I also don't know where this function is going?
    if self.state.config.device_code==grandprimevelte: 
        for line in run_command("adb shell twrp wipe data", bin_path):
            yield line
    else:
        for line in run_command("adb shell twrp format data", bin_path):
            yield line
I assume this is in the tooling module. There you have no access to the components of the views and the state since I try to keep the direct device interactions as separate from the rest as I could manage.
What you could try, is to pass a use_wipe boolean flag to the function to trigger this change.
Or, just let the format fail, catch that and retry with wipe data. If this doesn't break adb, I think I would prefer this.

Uhhhhhm I must also say, that I am a total beginner in python and only hack myself around things... If it would be possible, please make the changes yourself. I am also not really available for coding until next Sunday so yeah...

MagicLike · 2023-04-16T13:05:20Z

I will try it myself now once...

MagicLike · 2023-04-16T13:26:08Z

@tsterbak Ok, I am not really getting anywhere...
I tried to do it using try and except, but it won't really work:

    try:
        for line in run_command("adb shell twrp format data", bin_path):
            yield line
    except:
        print("Data partition can not be formatted, attempting to wipe it.")
        for line in run_command("adb shell twrp wipe data", bin_path):
            yield line

tsterbak · 2023-04-19T17:35:55Z

Hey @MagicLike, I implemented a small change where, if format data fails it is retried with wipe data. You can see the PR here: #142. Give it a try if you find time :) Hopefully that solves this issue.

MagicLike · 2023-04-23T15:11:33Z

Hey @MagicLike, I implemented a small change where, if format data fails it is retried with wipe data. You can see the PR here: #142. Give it a try if you find time :) Hopefully that solves this issue.

I am gonna try it out rn!

MagicLike · 2023-04-24T08:55:16Z

@tsterbak Ok, I tested it yesterday multiple times and the log does not show any indication, that there was a retry with wipe data...

tsterbak · 2023-04-24T09:07:03Z

@tsterbak Ok, I tested it yesterday multiple times and the log does not show any indication, that there was a retry with wipe data...

Did you get the code from #142 to this branch before testing?

MagicLike · 2023-04-24T09:29:17Z

@tsterbak Ok, I tested it yesterday multiple times and the log does not show any indication, that there was a retry with wipe data...

Did you get the code from #142 to this branch before testing?

Jup, just copied the contents of tooling and pasted it into my local file...

tsterbak · 2023-04-24T10:08:55Z

Jup, just copied the contents of tooling and pasted it into my local file...

Ah wait! I made a mistake... I'll fix the code in the other branch now.

MagicLike · 2023-04-24T20:15:25Z

Jup, just copied the contents of tooling and pasted it into my local file...

Ah wait! I made a mistake... I'll fix the code in the other branch now.

Hmmm, the behaviour is still the same... data is not wiped.

tsterbak · 2023-04-24T20:54:47Z

Hmmm, the behaviour is still the same... data is not wiped.

Thanks for testing again.
It's a bit hard to tell what is happening... 🤔 Is there something new in the logs?

MagicLike · 2023-04-25T18:28:20Z

Hmmm, the behaviour is still the same... data is not wiped.

Thanks for testing again. It's a bit hard to tell what is happening... thinking Is there something new in the logs?

Sadly not...

tsterbak · 2023-04-28T16:19:58Z

Sadly not...

Hm, that's a pity. So hard to tell what is going on...
From the above logs, it also looks like the adb already fails at "wait-for-recovery". Is there a way to know if the device's adb version already supports that?

MagicLike · 2023-04-29T13:58:05Z

Sadly not...

Hm, that's a pity. So hard to tell what is going on...
From the above logs, it also looks like the adb already fails at "wait-for-recovery". Is there a way to know if the device's adb version already supports that?

I actually don't know, but I tried to run the command seperately and it returns no error...

tsterbak · 2023-05-06T09:55:54Z

Did it work now?

MagicLike · 2023-05-06T09:57:40Z

Did it work now?

Not quite - I am gonna do another test on a fresh codebase directly pulled from main and insert the config and tooling changes. Let's see...

tsterbak · 2023-05-06T10:02:12Z

Not quite - I am gonna do another test on a fresh codebase directly pulled from main and insert the config and tooling changes. Lets see...

We'll, let's see. Otherwise I have to find a way to iterate on this faster to figure out what is going wrong and how to fix it...

MagicLike · 2023-05-06T10:13:19Z

Not quite - I am gonna do another test on a fresh codebase directly pulled from main and insert the config and tooling changes. Lets see...

We'll, let's see. Otherwise I have to find a way to iterate on this faster to figure out what is going wrong and how to fix it...

Here is the complete log - it still does not seem to do anything with the data partition. Maybe make it standard to first wipe it and - if supported - format it?

openandroidinstaller.log

MagicLike · 2023-05-09T10:07:42Z

Maybe make it standard to first wipe it and - if supported - format it?

I guess that would be a good option... (?)

tsterbak · 2023-05-10T10:16:27Z

I guess that would be a good option... (?)

I'm a bit reluctant to change the current command sequence since it has been tested with a lot of devices. But maybe this is the way to go.

I gave it another try and make it explicitly fail if the command is unknown. And then resolve that by retrying. Hopefully this works...

MagicLike · 2023-05-10T15:17:09Z

I guess that would be a good option... (?)

I'm a bit reluctant to change the current command sequence since it has been tested with a lot of devices. But maybe this is the way to go.

I gave it another try and make it explicitly fail if the command is unknown. And then resolve that by retrying. Hopefully this works...

Uhhhhmmmm

Exception in thread Thread-89:
Traceback (most recent call last):
  File "/*/.pyenv/versions/3.9.10/lib/python3.9/threading.py", line 973, in _bootstrap_inner
    self.run()
  File "/*/.pyenv/versions/3.9.10/lib/python3.9/threading.py", line 910, in run
    self._target(*self._args, **self._kwargs)
  File "/*/openandroidinstaller/openandroidinstaller/views/install_view.py", line 190, in run_install
    for line in adb_twrp_wipe_and_install(
  File "/*/openandroidinstaller/openandroidinstaller/tooling.py", line 224, in adb_twrp_wipe_and_install
    for line in adb_twrp_format_data(bin_path):
  File "*/openandroidinstaller/openandroidinstaller/tooling.py", line 89, in logging
    for line in func(*args, **kwargs):
  File "/*/openandroidinstaller/openandroidinstaller/tooling.py", line 186, in adb_twrp_format_data
    if "Unrecognized script command" in line:
TypeError: argument of type 'bool' is not iterable

tsterbak · 2023-05-10T16:31:05Z

Uhhhhmmmm

Ahhh, stupid mistake... Sorry for wasting your time...

tsterbak · 2023-05-10T16:32:53Z

Should be fixed now.

MagicLike · 2023-05-11T06:05:13Z

Uhhhhmmmm

Ahhh, stupid mistake... Sorry for wasting your time...

No problem, without me "wasting" time, the issue wouldn't have been discovered 😁

MagicLike · 2023-05-11T06:05:43Z

Should be fixed now.

Gonna test it out later today!

MagicLike · 2023-05-11T18:02:50Z

@tsterbak It finally works!

2023-05-11 19:10:05.879 | INFO     | tooling:logging:88 - Perform a factory reset with adb and twrp. - Paramters: {}
2023-05-11 19:10:05.882 | INFO     | tooling:run_command:59 - Run command: ['/*/openandroidinstaller/openandroidinstaller/bin/adb', 'shell', 'twrp', 'format', 'data']
2023-05-11 19:10:05.936 | INFO     | tooling:run_command:73 - E:Unrecognized script command: 'format'
2023-05-11 19:10:05.938 | INFO     | tooling:run_command:73 - Done processing script file
2023-05-11 19:10:05.939 | INFO     | tooling:adb_twrp_format_data:192 - Factory reset with `adb twrp format data` failed. Trying `adb twrp wipe data` now.
2023-05-11 19:10:06.940 | INFO     | tooling:logging:88 - Wipe the selected partition with adb and twrp. - Paramters: {'bin_path': PosixPath('/*/openandroidinstaller/openandroidinstaller/bin'), 'partition': 'data'}
2023-05-11 19:10:06.941 | INFO     | tooling:run_command:59 - Run command: ['/*/openandroidinstaller/openandroidinstaller/bin/adb', 'shell', 'twrp', 'wipe', 'data']
2023-05-11 19:10:07.826 | INFO     | tooling:run_command:73 - Formatting Cache using make_ext4fs...
2023-05-11 19:10:07.827 | INFO     | tooling:run_command:73 - Wiping data without wiping /data/media ...
2023-05-11 19:10:07.828 | INFO     | tooling:run_command:73 - Done.
2023-05-11 19:10:07.829 | INFO     | tooling:run_command:73 - Done processing script file

MagicLike · 2023-05-11T18:03:40Z

~~I will just test it out with the older TWRP (the official version), to verify that it also works with that!~~

So please wait with merging both PRs!

MagicLike · 2023-05-11T18:11:53Z

@tsterbak Uhhhhh this happens, when I want to click continue after installing:

Exception in thread Thread-120:
Traceback (most recent call last):
  File "/*/.pyenv/versions/3.9.10/lib/python3.9/threading.py", line 973, in _bootstrap_inner
    self.run()
  File "/*/.pyenv/versions/3.9.10/lib/python3.9/threading.py", line 910, in run
    self._target(*self._args, **self._kwargs)
  File "/*/openandroidinstaller/openandroidinstaller/openandroidinstaller.py", line 185, in to_next_view
    self.view.update()
  File "/*/.cache/pypoetry/virtualenvs/openandroidinstaller-2qNGYNIQ-py3.9/lib/python3.9/site-packages/flet/control.py", line 259, in update
    self.__page.update(self)
  File "/*/.cache/pypoetry/virtualenvs/openandroidinstaller-2qNGYNIQ-py3.9/lib/python3.9/site-packages/flet/page.py", line 221, in update
    added_controls = self.__update(*controls)
  File "/*/.cache/pypoetry/virtualenvs/openandroidinstaller-2qNGYNIQ-py3.9/lib/python3.9/site-packages/flet/page.py", line 231, in __update
    control.build_update_commands(self._index, added_controls, commands)
  File "/*/.cache/pypoetry/virtualenvs/openandroidinstaller-2qNGYNIQ-py3.9/lib/python3.9/site-packages/flet/control.py", line 328, in build_update_commands
    innerCmds = ctrl._build_add_commands(
  File "/*/.cache/pypoetry/virtualenvs/openandroidinstaller-2qNGYNIQ-py3.9/lib/python3.9/site-packages/flet/control.py", line 381, in _build_add_commands
    self._build()
  File "/*/.cache/pypoetry/virtualenvs/openandroidinstaller-2qNGYNIQ-py3.9/lib/python3.9/site-packages/flet/user_control.py", line 12, in _build
    content = self.build()
  File "/*/openandroidinstaller/openandroidinstaller/views/success_view.py", line 54, in build
    Markdown(
  File "/*/openandroidinstaller/openandroidinstaller/styles.py", line 30, in __init__
    super().__init__(
TypeError: flet.markdown.Markdown.__init__() got multiple values for keyword argument 'on_tap_link'

tsterbak · 2023-05-12T14:25:47Z

@tsterbak Uhhhhh this happens, when I want to click continue after installing:

Oh, I see... It should be fixed now :)

MagicLike · 2023-05-12T18:18:50Z

@tsterbak Uhhhhh this happens, when I want to click continue after installing:

Oh, I see... It should be fixed now :)

Everything works, flashing is fine - ready to merge! 😃

If `adb twrp format data` fails, retry with `adb twrp wipe data`. This should address issues with old versions of TWRP as found in #140.

MagicLike added 2 commits April 15, 2023 16:08

Added config for grandprimevelte

49cff08

Added grandprimevelte to list

0fd6bba

Added grandprimevelte to the list, but marked it as `untested`.

tsterbak added the device Request to add or improve a specific device. label Apr 15, 2023

tsterbak added this to the Release Beta 0.4.3 milestone Apr 15, 2023

tsterbak mentioned this pull request Apr 19, 2023

If adb twrp format data fails, retry with adb twrp wipe data #142

Merged

Marked grandprimevelte as tested

37dbeba

MagicLike marked this pull request as ready for review May 12, 2023 18:18

tsterbak added a commit that referenced this pull request May 13, 2023

If adb twrp format data fails, retry with adb twrp wipe data (#142)

ad81cca

If `adb twrp format data` fails, retry with `adb twrp wipe data`. This should address issues with old versions of TWRP as found in #140.

tsterbak merged commit 6d136df into openandroidinstaller-dev:dev May 13, 2023

Support for Samsung Galaxy Grand Prime VE #140

Support for Samsung Galaxy Grand Prime VE #140

Conversation

MagicLike commented Apr 15, 2023

tsterbak commented Apr 15, 2023

MagicLike commented Apr 15, 2023

tsterbak commented Apr 15, 2023

MagicLike commented Apr 15, 2023

tsterbak commented Apr 15, 2023

MagicLike commented Apr 15, 2023

MagicLike commented Apr 15, 2023

MagicLike commented Apr 15, 2023

MagicLike commented Apr 15, 2023 • edited Loading

MagicLike commented Apr 15, 2023 • edited Loading

tsterbak commented Apr 15, 2023

MagicLike commented Apr 15, 2023

MagicLike commented Apr 16, 2023

tsterbak commented Apr 16, 2023

tsterbak commented Apr 16, 2023

tsterbak commented Apr 16, 2023

MagicLike commented Apr 16, 2023 • edited Loading

MagicLike commented Apr 16, 2023

tsterbak commented Apr 16, 2023

MagicLike commented Apr 16, 2023

MagicLike commented Apr 16, 2023

MagicLike commented Apr 16, 2023

tsterbak commented Apr 19, 2023

MagicLike commented Apr 23, 2023

MagicLike commented Apr 24, 2023

tsterbak commented Apr 24, 2023 • edited Loading

MagicLike commented Apr 24, 2023

tsterbak commented Apr 24, 2023 • edited Loading

MagicLike commented Apr 24, 2023

tsterbak commented Apr 24, 2023 • edited Loading

MagicLike commented Apr 25, 2023

tsterbak commented Apr 28, 2023

MagicLike commented Apr 29, 2023

tsterbak commented May 6, 2023

MagicLike commented May 6, 2023 • edited Loading

tsterbak commented May 6, 2023

MagicLike commented May 6, 2023

MagicLike commented May 9, 2023

tsterbak commented May 10, 2023

MagicLike commented May 10, 2023

tsterbak commented May 10, 2023

tsterbak commented May 10, 2023

MagicLike commented May 11, 2023

MagicLike commented May 11, 2023

MagicLike commented May 11, 2023

MagicLike commented May 11, 2023 • edited Loading

MagicLike commented May 11, 2023

tsterbak commented May 12, 2023

MagicLike commented May 12, 2023

MagicLike commented Apr 15, 2023 •

edited

Loading

MagicLike commented Apr 15, 2023 •

edited

Loading

MagicLike commented Apr 16, 2023 •

edited

Loading

tsterbak commented Apr 24, 2023 •

edited

Loading

tsterbak commented Apr 24, 2023 •

edited

Loading

tsterbak commented Apr 24, 2023 •

edited

Loading

MagicLike commented May 6, 2023 •

edited

Loading

MagicLike commented May 11, 2023 •

edited

Loading