Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #145

Merged
merged 2 commits into from
Apr 27, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ Every step in the config file corresponds to one view in the application. These
- `call_button_with_input`: Display the content text, an input field and a button that runs a given command. The inputtext, can be used in the command by using the `<inputtext>` placeholder in the command field. After the command is run, a confirm button is displayed to allow the user to move to the next step.
- `link_button_with_confirm`: Display a button that opens a browser with a given link, confirm afterwards. Link is given in `link`.
- `img`: [OPTIONAL] Display an image on the left pane of the step view. Images are loaded from `openandroidinstaller/assets/imgs/`.
- `content`: str; The content text displayed alongside the action of the step. Used to inform the user about whats going on. For consistency and better readability the text should be moved into the next line using `>`.
- `content`: str; The content text displayed alongside the action of the step. Used to inform the user about what's going on. For consistency and better readability the text should be moved into the next line using `>`.
- `link`: [OPTIONAL] Link to use for the link button if type is `link_button_with_confirm`.
- `command`: [ONLY for call_button* steps] str; The command to run. One of `adb_reboot`, `adb_reboot_bootloader`, `adb_reboot_download`, `adb_sideload`, `adb_twrp_wipe_and_install`, `adb_twrp_copy_partitions`, `fastboot_boot_recovery`, `fastboot_unlock_with_code`, `fastboot_unlock`, `fastboot_oem_unlock`, `fastboot_get_unlock_data`, `fastboot_reboot`, `heimdall_flash_recovery`.
- `allow_skip`: [OPTIONAL] boolean; If a skip button should be displayed to allow skipping this step. Can be useful when the bootloader is already unlocked.
Expand Down
2 changes: 1 addition & 1 deletion openandroidinstaller/tooling.py
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ def add_logging(step_desc: str, return_if_fail: bool = False) -> Callable:

def logging_decorator(func) -> Callable:
def logging(*args, **kwargs) -> TerminalResponse:
logger.info(f"{step_desc} - Paramters: {kwargs}")
logger.info(f"{step_desc} - Parameters: {kwargs}")
for line in func(*args, **kwargs):
if (type(line) == bool) and not line:
logger.error(f"{step_desc} Failed!")
Expand Down
2 changes: 1 addition & 1 deletion openandroidinstaller/views/install_addons_view.py
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ def check_advanced_switch(e):

def run_install_addons(self, e):
"""
Run the addon installation process trough twrp.
Run the addon installation process through twrp.

Some parts of the command are changed by placeholders.
"""
Expand Down
2 changes: 1 addition & 1 deletion openandroidinstaller/views/install_view.py
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ def check_addons_switch(e):

def run_install(self, e):
"""
Run the installation process trough twrp.
Run the installation process through twrp.

Some parts of the command are changed by placeholders.
"""
Expand Down
4 changes: 2 additions & 2 deletions openandroidinstaller/views/step_view.py
Original file line number Diff line number Diff line change
Expand Up @@ -108,14 +108,14 @@ def check_advanced_switch(e):
self.progress_indicator = ProgressIndicator(expand=True)

# main controls
steps_indictor_img_lookup = {
steps_indicator_img_lookup = {
"Unlock the bootloader": "steps-header-unlock.png",
"Boot custom recovery": "steps-header-recovery.png",
}
self.right_view_header.controls = [
get_title(
f"{self.step.title}",
step_indicator_img=steps_indictor_img_lookup.get(self.step.title),
step_indicator_img=steps_indicator_img_lookup.get(self.step.title),
)
]
self.right_view.controls = [
Expand Down