Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.5.0-beta #191

Merged
merged 122 commits into from
Oct 2, 2023
Merged

Release 0.5.0-beta #191

merged 122 commits into from
Oct 2, 2023

Conversation

tsterbak
Copy link
Member

@tsterbak tsterbak commented Jul 29, 2023

This release adds:

  • Allow flashing a custom recovery with a toggle switch.
  • Display device specific notes at the image selection step (thanks to @anon1892)
  • Include the commands fastboot_flash_recovery and fastboot_reboot_recovery (thanks to @anon1892)
  • Add support for Samsung Galaxy S5 LTE (klte).
  • Add support for Mi439 (Redmi 7A & co.) (thanks to @anon1892)
  • Add support for lavender (Xiaomi Redmi Note 7) (thanks to @anon1892)
  • Add support for ginkgo (Xiaomi Redmi Note 8 / 8T) (thanks to @anon1892)
  • Add support for garden (Xiaomi Redmi 9A & co.) (thanks to @anon1892)
  • Add support for rosemary (Xiaomi Redmi Note 10S & co.) (thanks to @anon1892)
  • Add support for miatoll (Xiaomi Redmi Note 9 Pro / 9S ... Poco M2 Pro) (thanks to @anon1892)
  • Add support for davinci (Xiaomi Mi 9T / Redmi K20) (thanks to @anon1892)
  • Add support for raphael (Xiaomi Mi 9T Pro / Redmi K20 Pro) (thanks to @anon1892)
  • Add support for vayu (Poco X3 Pro) (thanks to @anon1892)
  • Add support for cupid (Xiaomi 12) (thanks to @anon1892)

Fixes:

Other news:

  • Actions for releases are upgraded (by @MagicLike)
  • Reworked the device request template as form (by @MagicLike)
  • Updated bootloader unlock info (by @freechelmi)

Todo:

  • Test flashing with already installed recovery.
  • Add new devices to the README
  • Update the website with new devices

@tsterbak tsterbak self-assigned this Jul 29, 2023
@tsterbak tsterbak added this to the Release Beta-Version 0.4.5 milestone Jul 29, 2023
Asked here : #270 

This device configuration file is not tested. (but should be working,
LineageOS installation process is the same as #222, and so the device
configuration file is)

Maybe @ojaghiradin want to test it?
Asked here : #285 

This device configuration file is not tested. (but should be working,
LineageOS installation process is the same as #226, and so the device
configuration file is)

Maybe @RedAuburn want to test it?
@tsterbak
Copy link
Member Author

This is most likely the final state for the release planed on Friday. Feel free to test it or suggest things that are missing :)
Thanks for everyone involved so far!

@anon1892
Copy link
Member

Wow, happy to see all these changes being merged!
There is occurrence of untested optional metadata in README, but not in device confs neither in code : I checked too fast or it was forgotten in the process? (The code just shows a warning when the device is untested...)

@tsterbak
Copy link
Member Author

There is occurrence of untested optional metadata in README, but not in device confs neither in code : I checked too fast or it was forgotten in the process? (The code just shows a warning when the device is untested...)

I removed it from the configs, because the config validation failed. But good point, I will better fix the validation and put the metadata field back, where required :)

@MagicLike
Copy link
Member

There is occurrence of untested optional metadata in README, but not in device confs neither in code : I checked too fast or it was forgotten in the process? (The code just shows a warning when the device is untested...)

I removed it from the configs, because the config validation failed. But good point, I will better fix the validation and put the metadata field back, where required :)

Will you fix it before the release or will it be part of 0.4.6 / a hotfix?

@tsterbak
Copy link
Member Author

Will you fix it before the release or will it be part of 0.4.6 / a hotfix?

I will fix it for this release.

@MagicLike
Copy link
Member

Will you fix it before the release or will it be part of 0.4.6 / a hotfix?

I will fix it for this release.

Then I will not approve the configs where a untested tag is needed 👍

@MagicLike
Copy link
Member

MagicLike commented Sep 27, 2023

Will you fix it before the release or will it be part of 0.4.6 / a hotfix?

I will fix it for this release.

@tsterbak Should we wait with the release for this? #287 (comment)

Copy link
Member

@MagicLike MagicLike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just waiting for the untested metadata to get fixed for cupid, davinci, ginko, miatoll, raphael, rosemary and vayu.

@tsterbak
Copy link
Member Author

@tsterbak Should we wait with the release for this? #287 (comment)

No, it think we can go out like this. This will also be a test for the "untested" metadata. If we start supporting untested devices, I guess this is the way to go :)

@tsterbak
Copy link
Member Author

This release will be postponed until Monday, since I want a bit more time for testing and not release Friday afternoon :D

@MagicLike MagicLike self-requested a review September 29, 2023 09:15
@RaptaG
Copy link
Contributor

RaptaG commented Oct 1, 2023

Are the upcoming devices tested?

@anon1892
Copy link
Member

anon1892 commented Oct 1, 2023

Are the upcoming devices tested?

Some are, some aren't, but behaves the same way others tested device do. See untested metadata.

@RaptaG
Copy link
Contributor

RaptaG commented Oct 1, 2023

Some are, some aren't, but behaves the same way others tested device do. See untested metadata.

I see, miatoll (my device) is untested sadly and I fear in case of something bad happens, I don't wanna risk my main device.. Does anybody here who has this model (and is willing to) test it?

@tsterbak tsterbak changed the title Release 0.4.5-beta Release 0.5.0-beta Oct 2, 2023
@tsterbak tsterbak merged commit cf505c8 into main Oct 2, 2023
@tsterbak
Copy link
Member Author

tsterbak commented Oct 2, 2023

It is released now! 🎊
Also, I decided to release it as 0.5.0-beta, since quite a lot of things were added and I thought following semantic versioning a bit better would be good.

Great work everyone involved! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install OS progress goes to 100% but need more time to complete
5 participants