Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a Doc folder to put documentation #198

Merged
merged 9 commits into from
Aug 5, 2023
Merged

a Doc folder to put documentation #198

merged 9 commits into from
Aug 5, 2023

Conversation

Heus-Sueh
Copy link
Contributor

I think it's ok

@tsterbak
Copy link
Member

Thanks for reacting so fast :)

Could you also check if there are links pointing to some of the sections or content of it on the website?
https://github.com/openandroidinstaller-dev/openandroidinstaller-dev.github.io
If you want you could open a PR for it (otherwise I can make the changes). (If you do, make sure to include the changes in the templates as well as in the respective public files.)

@tsterbak tsterbak added the documentation Improvements or additions to documentation label Jul 30, 2023
@tsterbak
Copy link
Member

Probably a bit pedantic, but could you unify the upper/lowercase of the new files? 😅

@tsterbak
Copy link
Member

Otherwise it looks really good :)

@Heus-Sueh
Copy link
Contributor Author

Could you also check if there are links pointing to some of the sections or content of it on the website?

I'll check

Probably a bit pedantic, but could you unify the upper/lowercase of the new files? 😅

ok

@MagicLike
Copy link
Member

Oh, maybe the CONTRIBUTING.md should also be adapted, to link to the detailed docs...

@Heus-Sueh
Copy link
Contributor Author

Oh, maybe the CONTRIBUTING.md should also be adapted, to link to the detailed docs...

it's a good idea but maybe in another PR

@Heus-Sueh
Copy link
Contributor Author

@tsterbak is it ok to merge now?

@tsterbak
Copy link
Member

@tsterbak is it ok to merge now?

I want to do it in a calm moment, when I would have time to fix something.

@Heus-Sueh
Copy link
Contributor Author

@tsterbak is it ok to merge now?

I want to do it in a calm moment, when I would have time to fix something.

no problem

@tsterbak tsterbak merged commit 2b582e8 into openandroidinstaller-dev:main Aug 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants