Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new images to GUI #211

Closed
wants to merge 4 commits into from
Closed

Add new images to GUI #211

wants to merge 4 commits into from

Conversation

tejasraman
Copy link

@tejasraman tejasraman commented Jul 31, 2023

This PR aims to add new images to OpenAndroidInstaller. PR uses 500x500 files with similar image sizes to previous image sizes. I also have vector files if needed. @tsterbak

@MagicLike
Copy link
Member

Would it be possible to add these images as SVGs? That would eliminate scaling issues and reduce file size. see #100

@tejasraman
Copy link
Author

Please read the original PR; vector images are available. Vector images would be relatively simple to implement, I’ll try to do it

@tsterbak tsterbak added this to the Release Beta-Version 0.4.5 milestone Aug 4, 2023
@tsterbak tsterbak added the enhancement New feature or request label Aug 4, 2023
@tsterbak tsterbak changed the base branch from main to dev August 4, 2023 06:54
@tsterbak
Copy link
Member

tsterbak commented Aug 4, 2023

From my point of view, this would be ready to be merged. But no hurry, if you want to add something it can wait :)
Thanks a lot for the nice visuals!

Actually, the step-indicators are probably also some images that would need attention. If you want to have a look ;)

@tejasraman
Copy link
Author

From my point of view, this would be ready to be merged. But no hurry, if you want to add something it can wait :)

Thanks a lot for the nice visuals!

Actually, the step-indicators are probably also some images that would need attention. If you want to have a look ;)

I made transparent versions and I want to add slightly higher resolution images.... and add a new steps indicator. I will try to add those today and commit those to my repo

@tsterbak
Copy link
Member

tsterbak commented Aug 4, 2023

I made transparent versions and I want to add slightly higher resolution images.... and add a new steps indicator. I will try to add those today and commit those to my repo

Awesome! Thanks a lot! 🙂 🥳
There is no hurry, there is still some time till the next release. I would just merge PRs that are complete and ready 😊

@tejasraman
Copy link
Author

👍👍

@tsterbak
Copy link
Member

Hi @tejasraman, did you make any progress on this? Do you need some input from me? 🙂

@tejasraman
Copy link
Author

tejasraman commented Aug 22, 2023

Hi @tejasraman, did you make any progress on this? Do you need some input from me? 🙂

I have made progress and reinstalled my os so it's on my cloud drive now... will upload it to git soon

@MagicLike MagicLike linked an issue Sep 8, 2023 that may be closed by this pull request
@tsterbak
Copy link
Member

Hey @tejasraman, I'm planning a new release at the end of the month and I would be amazing to ship the upgraded visuals in it :)

If you are busy or so, not an issue. I just wanted to give you a heads up if you want to get the stuff included quickly :)

@tejasraman
Copy link
Author

Hey @tejasraman, I'm planning a new release at the end of the month and I would be amazing to ship the upgraded visuals in it :)

If you are busy or so, not an issue. I just wanted to give you a heads up if you want to get the stuff included quickly :)

I'll finish them and PR them tomorrow, thanks!

@tsterbak
Copy link
Member

Hey, any news on this? I'm slowing wrapping up the new release and I would really love to have this included :)

@tejasraman
Copy link
Author

Hey, any news on this? I'm slowing wrapping up the new release and I would really love to have this included :)

Sorry, I’ve been busy lately. I’ll do this today, I promise

@MagicLike
Copy link
Member

@tejasraman A little heads up: the planned release is less than two days away... ^^

@tsterbak
Copy link
Member

@tejasraman any news on this? There will be another release soonish and I would really love to get this included :)

@SirRGB
Copy link
Contributor

SirRGB commented Oct 19, 2023

samsung-buttons-bixbi/samsung-buttons text changed in this commit.

Previously it was "press until the screen turns black, then press"
Now it is "press until screen turns black, then press", so the "the" has been purged.

Doesnt sound right to me, but other than that it looks good imo.
It doesnt have to be perfect, you can always pr again.

@tejasraman
Copy link
Author

@tejasraman any news on this? There will be another release soonish and I would really love to get this included :)

sorry for being late, I'm doing it right now

@tsterbak tsterbak removed this from the Release Beta-Version 0.5.1 milestone Oct 29, 2023
@MagicLike
Copy link
Member

Any updates on this one?

@SirRGB SirRGB mentioned this pull request Dec 2, 2023
@tejasraman tejasraman closed this by deleting the head repository Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use SVG format for images inside app
4 participants