Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update configs for additional partitions and flash vendor_boot.img #317

Merged
merged 11 commits into from
Oct 31, 2023

Conversation

tsterbak
Copy link
Member

@tsterbak tsterbak commented Oct 7, 2023

The PR adds:

  • updates for some OnePlus and Pixel configs with make use of the flashing of additional partitions if needed for Android 13
  • Allow flashing of the vendor_boot partition
  • Add --disable-verity --disable-verification to flash vbmeta command
  • support for alioth (Redmi K40 / Mi 11X / Poco F3) (thanks to @anon1892)

Resolves #303 and #304 .

@tsterbak tsterbak added the enhancement New feature or request label Oct 7, 2023
@tsterbak tsterbak added this to the Release Beta-Version 0.5.1 milestone Oct 7, 2023
@tsterbak tsterbak self-assigned this Oct 7, 2023
@tsterbak tsterbak changed the base branch from main to dev October 7, 2023 09:35
@tsterbak tsterbak changed the title Update configs for additional partitions Update configs for additional partitions and flash vendor_boot.img Oct 7, 2023
@tsterbak
Copy link
Member Author

Actually, I wonder if this whole extra step for flashing additional partitions can be pulled into the "boot recovery" step all together. Maybe I'll try that

@tsterbak tsterbak mentioned this pull request Oct 13, 2023
@tsterbak
Copy link
Member Author

tsterbak commented Oct 13, 2023

@anon1892 I tried to pull flash additional partitions in the fastboot_flash_recovery function, to simplify the steps and remove the necessity to perform an empty step, if you don't need the partitions now.

The change is currently only implemented for Mi439 for testing purposes. Do you have the device available and could give this a try? Then I would implement it for more devices.

@anon1892
Copy link
Member

@tsterbak Yes, I may test it next week, I'm busy now...

@tsterbak
Copy link
Member Author

@tsterbak Yes, I may test it next week, I'm busy now...

No worries :) looking forward to hear from you :)

@anon1892
Copy link
Member

Hello!

I just tested this PR to install Lineage 20 from MiUI on my pine, and it worked fine!
If I select “recovery already flashed”, I can't choose additional partitions, but I think it's the wanted behavior (just to be sure)

@tsterbak tsterbak added the hacktoberfest-accepted PR accepted for Hacktoberfest label Oct 29, 2023
@anon1892
Copy link
Member

I was looking at Lineage documentation for #275, and this line

for line in run_command("fastboot reboot recovery", bin_path):

have to be replaced with fastboot reboot-recovery

I tested on my lavender, it to the same (in both cases I have to push Vol+ to boot, the line is equivalent to fastboot reboot). But we have to be sure that all phones support fastboot reboot-recovery at least the same way they support fastboot reboot recovery...

@tsterbak
Copy link
Member Author

Thanks for figuring that out!

Do you want to go through the configs of the Xiaomi devices and update that?
For the fastboot reboot-recovery I would advise to create a new function analogous to fastboot reboot recovery and use that if required.

@anon1892
Copy link
Member

I looked at it on the internet, both look interchangeable and can be used in the same way. On my tested devices, both are equivalent. Since this function is only used by Xiaomi devices, the only regression it can create is for vayu : it's a “tested” device, but not by me...
I don't think it's necessary to create a second function for that.

Do you want to go through the configs of the Xiaomi devices and update that?

What ?

@tsterbak
Copy link
Member Author

What ?

Sorry for not being precise, I didn't get it properly. If that method is only used for Xiaomi devices, we should put a comment there in the function and then I guess its fine to change it to reboot-recovery.

The other question I had, was if the reboot recovery is even needed if you have to press the buttons either way. I have a MI 9 Lite (pyxis) device now and tested it here: openandroidinstaller/assets/configs/pyxis.yaml
For this device reboot recovery and reboot-recovery do nothing after flashing recovery, so I have to press the buttons to get it going. Is this the same for your devices?

@anon1892
Copy link
Member

Yes, for now it's only used by Xiaomi devices (proof)

Yes, for my lavender it's the same : I always need to press Vol+. For my dandelion, both works without pressing any button. For alioth, reboot-recovery seems to be working the right way according to Lineage documentation.

Based on reworked (working) Mi439 config in #317

Asks for `vendor_boot`, as depicted by Lineage 20 documentation. Maybe
it has to be optional, since TWRP documentation doesn't mention it?

Related to #275
Untested
@tsterbak tsterbak merged commit 342369f into dev Oct 31, 2023
@tsterbak tsterbak deleted the update-configs-for-additional-partitions branch October 31, 2023 16:08
README.md Outdated Show resolved Hide resolved
@MagicLike MagicLike linked an issue Oct 31, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest hacktoberfest-accepted PR accepted for Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add flashing additional images to configs where necessary Add supprt for flashing vendor_boot.img
3 participants