-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update configs for additional partitions and flash vendor_boot.img #317
Conversation
Actually, I wonder if this whole extra step for flashing additional partitions can be pulled into the "boot recovery" step all together. Maybe I'll try that |
… nessecary (only for Mi439)
@anon1892 I tried to pull flash additional partitions in the fastboot_flash_recovery function, to simplify the steps and remove the necessity to perform an empty step, if you don't need the partitions now. The change is currently only implemented for |
@tsterbak Yes, I may test it next week, I'm busy now... |
No worries :) looking forward to hear from you :) |
Hello! I just tested this PR to install Lineage 20 from MiUI on my |
I was looking at Lineage documentation for #275, and this line
have to be replaced with fastboot reboot-recovery
I tested on my lavender, it to the same (in both cases I have to push Vol+ to boot, the line is equivalent to |
Thanks for figuring that out! Do you want to go through the configs of the Xiaomi devices and update that? |
I looked at it on the internet, both look interchangeable and can be used in the same way. On my tested devices, both are equivalent. Since this function is only used by Xiaomi devices, the only regression it can create is for
What ? |
Sorry for not being precise, I didn't get it properly. If that method is only used for Xiaomi devices, we should put a comment there in the function and then I guess its fine to change it to The other question I had, was if the |
Yes, for now it's only used by Xiaomi devices (proof) Yes, for my |
The PR adds:
Resolves #303 and #304 .