Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xiaomi Redmi Note 10 Pro (sweet) M2101K6G config #405

Merged
merged 8 commits into from
Feb 7, 2024

Conversation

BjornW
Copy link
Contributor

@BjornW BjornW commented Dec 29, 2023

I've added the config for the Xiaomi Redmi Note 10 Pro (sweet) with modelnr: M2101K6G (with some help from @anon1892, thank you!) . According to the LineageOS wiki there are three variants of this phone. This config has been created and successfully tested for the M2101K6G model.

I've also added this phone to the table of supported devices in the README.md.

This pull-request would solve my own requested support issue #404

Please let me know if there are any issues with this PR preventing it from being merged. Thanks!

There are more variants of this phone. This config is tested on the
variant with model nr: M2101K6G
I'm able to flash my Xiaomi Redmi Note 10 Pro M2101K6G with this config.
As far as I can tell the phone works as intended.
@MagicLike MagicLike linked an issue Dec 29, 2023 that may be closed by this pull request
2 tasks
@MagicLike MagicLike added the device Request to add or improve a specific device. label Dec 29, 2023
openandroidinstaller/assets/configs/sweet.yaml Outdated Show resolved Hide resolved
openandroidinstaller/assets/configs/sweet.yaml Outdated Show resolved Hide resolved
openandroidinstaller/assets/configs/sweet.yaml Outdated Show resolved Hide resolved
@tsterbak
Copy link
Member

Hey @BjornW great work!
Looks good so far, only minor changes and this is good to go :)

@tsterbak
Copy link
Member

@BjornW any updates on this? I would love to get this merged for the next release :)

@BjornW
Copy link
Contributor Author

BjornW commented Jan 18, 2024

@BjornW any updates on this? I would love to get this merged for the next release :)

Hi! sorry, I was sick for a few days and after that had to take of family members who also got sick. I've worked through the requested changes, please let me know if this can be merged. Thanks!

BjornW and others added 3 commits January 18, 2024 21:05
Change line order upon request

Co-authored-by: MagicLike <magiclike@magiclike.net>
untested: false is not required as this is the default. Changed upon request.

Co-authored-by: MagicLike <magiclike@magiclike.net>
@tsterbak tsterbak changed the base branch from main to dev February 7, 2024 11:52
@tsterbak
Copy link
Member

tsterbak commented Feb 7, 2024

@anon1892 Could you have a look? Then I would be happy to merge this :)

Copy link
Member

@anon1892 anon1892 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tsterbak tsterbak merged commit 45b0287 into openandroidinstaller-dev:dev Feb 7, 2024
@tsterbak
Copy link
Member

tsterbak commented Feb 7, 2024

Hi! sorry, I was sick for a few days and after that had to take of family members who also got sick. I've worked through the requested changes, please let me know if this can be merged. Thanks!

Looks good, I merged it :) It will be available in the next release. Thanks a lot all of you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
device Request to add or improve a specific device.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Xiaomi Redmi Note 10 Pro (sweet) M2101K6G
4 participants