Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add griffin and cheesedump support #66

Merged
merged 2 commits into from
Feb 7, 2023
Merged

add griffin and cheesedump support #66

merged 2 commits into from
Feb 7, 2023

Conversation

SirRGB
Copy link
Contributor

@SirRGB SirRGB commented Feb 3, 2023 •
edited
Loading

  • copy pasta from cedric and guacamole

@SirRGB
add griffin support
5477333 
* copy pasta from cedric
@SirRGB
add cheesedump support
d823a5a 
* copy pasta from guacamole
@SirRGB
Copy link
Contributor Author

SirRGB commented Feb 3, 2023

tested griffin carbonrom and cheeseburger crdroid
flashed twrp/rom on already unlocked bootloader

@tsterbak tsterbak self-assigned this Feb 4, 2023
@tsterbak tsterbak added the device Request to add or improve a specific device. label Feb 4, 2023
@tsterbak tsterbak changed the base branch from main to dev February 4, 2023 08:42
@tsterbak
Copy link
Member

tsterbak commented Feb 4, 2023

Hey, thank you for your work! This will be added in the next release 🙂

One quick question, did the naming convention of the config files and device code work for you for the OnePlus devices?
I found it a bit annoying and confusing so far, and for the OnePlus devices I added, I actually hardcoded a mapping (e.g. OnePlus6 to guacamole and back) to keep the file name the device code. But if the approach you took worked fine for you, I might remove the mapping and adapt to your approach. How was your experience? 🙂

@tsterbak tsterbak self-requested a review February 4, 2023 08:47
@tsterbak tsterbak assigned SirRGB and unassigned tsterbak Feb 4, 2023
@SirRGB
Copy link
Contributor Author

SirRGB commented Feb 4, 2023

Well I just used the app when trying to bringup the device and it didnt work when the file was named after the codename and said "unknown device: OnePlus5" so I just went for that and it worked. Im guessing with the 5T name tho, but it would fit the naming convention.

@SirRGB SirRGB changed the title add griffin support add griffin and cheesedump support Feb 4, 2023
tsterbak
tsterbak approved these changes Feb 7, 2023
View reviewed changes
Copy link
Member

@tsterbak tsterbak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. This will go in the next release

@tsterbak tsterbak changed the base branch from dev to release/0.3.5-alpha February 7, 2023 09:55
@tsterbak tsterbak merged commit 6cdc802 into openandroidinstaller-dev:release/0.3.5-alpha Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsterbak tsterbak tsterbak approved these changes

Assignees

@SirRGB SirRGB

Labels
device Request to add or improve a specific device.
Projects
None yet
Milestone
Release Alpha 0.3.5
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SirRGB @tsterbak