Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve scripting component #75

Merged
merged 9 commits into from
Feb 9, 2023
Merged

Improve scripting component #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f8a4aaf
WIP
tsterbak Feb 8, 2023
56fef11
WIP
tsterbak Feb 9, 2023
f267dd6
Merge branch 'release/0.4.0-beta' into improve-cmd-interaction
tsterbak Feb 9, 2023
1c37547
Shell interactions optimized
tsterbak Feb 9, 2023
2544e39
Add some more tests for tooling functions
tsterbak Feb 9, 2023
93d8711
Fix advnaced toggle in install views; fix wiping partitions
tsterbak Feb 9, 2023
d280c14
Fix wiping cache after install
tsterbak Feb 9, 2023
b02c621
WIP
tsterbak Feb 9, 2023
3865d8f
Fix fastboot issue and clear error text at the right time
tsterbak Feb 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions openandroidinstaller/openandroidinstaller.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,21 +193,18 @@ def log_version_infos(bin_path):
"""Log the version infos of adb, fastboot and heimdall."""
# adb
adbversion = [
line for line in run_command("adb", ["version"], bin_path, enable_logging=False)
line for line in run_command("adb version", bin_path, enable_logging=False)
]
logger.info(f"{adbversion[1].strip()}")
# fastboot
fbversion = [
line
for line in run_command(
"fastboot", ["--version"], bin_path, enable_logging=False
)
for line in run_command("fastboot --version", bin_path, enable_logging=False)
]
logger.info(f"{fbversion[1].strip()}")
# heimdall
hdversion = [
line
for line in run_command("heimdall", ["info"], bin_path, enable_logging=False)
line for line in run_command("heimdall info", bin_path, enable_logging=False)
]
logger.info(f"Heimdall version: {hdversion[1].strip()}")

Expand Down
Loading