Better overlapping highlight allowance #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `isAnnotator` method can ignore the highlight spans, making it a simple call to `isAnnotator` when ignoring selections, rather than a loop that tries to escape the highlights. Close #466
Closed
aron
added a commit
that referenced
this pull request
Jan 17, 2015
Better overlapping highlight allowance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
isAnnotatormethod can ignore the highlight spans, making it asimple call to
isAnnotatorwhen ignoring selections, rather than aloop that tries to escape the highlights.
Close #466