-
-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch YAML parser to ruamel.yaml which uses YAML 1.2 #1042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbanty
approved these changes
May 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update! From what I could tell, ruamel.yaml.string
is only used for tests, so I moved it to a dev dependency. If that's wrong, though, please let me know!
dbanty
added a commit
that referenced
this pull request
May 18, 2024
This PR was created by Knope. Merging it will create a new release ### Breaking Changes #### `const` values in responses are now validated at runtime Prior to this version, `const` values returned from servers were assumed to always be correct. Now, if a server returns an unexpected value, the client will raise a `ValueError`. This should enable better usage with `oneOf`. PR #1024. Thanks @peter-greenatlas! #### Switch YAML parsing to 1.2 This change switches the YAML parsing library to `ruamel.yaml` which follows the YAML 1.2 specification. [There are breaking changes](https://yaml.readthedocs.io/en/latest/pyyaml/#defaulting-to-yaml-12-support) from YAML 1.1 to 1.2, though they will not affect most use cases. PR #1042 fixes #1041. Thanks @rtaycher! ### Features - allow Ruff 0.4 (#1031) ### Fixes #### Fix nullable and required properties in multipart bodies Fixes #926. > [!WARNING] > This change is likely to break custom templates. Multipart body handling has been completely split from JSON bodies. Co-authored-by: GitHub <github-actions@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1041
ruamel.yaml understands yaml1.2 which yaml doesn't support.
yaml 1.2 lacks norway issue