-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kloudfuse #176
base: master
Are you sure you want to change the base?
Add kloudfuse #176
Conversation
Can I please get review on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there, I left some comments for request changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you provide the file as a png as well as in a square format? Not using a square format would result in the logo not being displayed correctly but cropped instead
- datadog-agent | ||
- fluentbit | ||
- opentelemetry | ||
- prometheus |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to reference another id from within the components here. In that sense 'prometheus' does not exist as an id and the data model cannot be build correctly.
You can check the prometheus.yml file to see which id's are available and use whichever component is suitable e.g. 'prometheus-exposition-format' or 'prometheus-exporter'
name: kloudfuse | ||
description: Kloudfuse is a unified monitoring and observability platform covering metrics, traces and logs, events, etc. Kloudfuse supports all open source agents and data collection sources (prometheus, open telemetry, fluentbit, etc.) and also promql, logql and traceql. | ||
link: https://www.kloudfuse.com/ | ||
github: [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if there is no GitHub reference just remove the field altogether, just as within the definition for other commercial tools. E.g. AppDynamics also has no GitHub link in the component definition.
No description provided.