Merge pull request #624 from bbuchalter/fail_on_db_setup_2

Fix non-zero exit code for redeploy-internal-db

go/app/cli.go

@@ -1575,7 +1575,10 @@ func Cli(command string, strict bool, instance string, destination string, owner
 	case registerCliCommand("redeploy-internal-db", "Meta, internal", `Force internal schema migration to current backend structure`):
 		{
 			config.RuntimeCLIFlags.ConfiguredVersion = ""
-			inst.ReadClusters()
+			_, err := inst.ReadClusters()
+			if err != nil {
+				log.Fatale(err)
+			}
 			fmt.Println("Redeployed internal db")
 		}
 	case registerCliCommand("internal-suggest-promoted-replacement", "Internal", `Internal only, used to test promotion logic in CI`):

tests/integration/test.sh

@@ -149,6 +149,7 @@ deploy_internal_db() {
   bash $exec_command_file 1> $test_outfile 2> $test_logfile
   if [ $? -ne 0 ] ; then
     echo "ERROR deploy internal db failed"
+    cat $test_logfile
     return 1
   fi
   echo "- deploy_internal_db result: $?"