This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
emergentlyRestartReplicationOnTopologyInstance fixes #1010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- restart replication fully (both SQL and IO threads) - fix concurrency/itration bug - slightly more logging Yesterday I observed a situation where stop slave io_thread; start slave io_thread; was not enough to make a replica identify that it's master is broken. By stopping replication completely I hope this mitigates such behavior
shlomi-noach
force-pushed
the
emerently-restart-repication-logging
branch
from
2645e5a to
2893aec
Compare
shlomi-noach
temporarily deployed
to
production/mysql_cluster=conductor
|
Thanks @shlomi-noach 👍 |
shlomi-noach
had a problem deploying
to
production/mysql_cluster=conductor
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yesterday we observed a situation where
stop slave io_thread; start slave io_thread;was not enough to make a replica identify that it's master is broken. By stopping replication completely I hope this mitigates such behavior.cc @timvaillancourt