introducing SkipMaxScaleCheck config #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
SkipMaxScaleCheckis set totrue(default isfalse),orchestratorskips any checks formaxscaleservers.People who never ever have any
maxscalebinlog server in their topology (not to be confused with maxscale load balancer, which is completely unrelated to this PR) should set this variable totrue. 99.9999999% of people don't havemaxscalebinlog servers in their setups.The reason for this flag: when connecting to a server,
orchestratorfirst checks whether it is amaxscaleserver, becausemaxscaleis very picky about the type of queries it can respond to. So firstorchestratorneeds to determine what is the type of queries valid to issue.If a server is offline or down, what we get in our error logs is that the
maxscalecheck has failed. I don't havemaxscaleand most people don't and this message actually bothers me.But more importantly it is wasting a round trip. For remote servers with high latency saving a single round trip is a worthy change (and I will proceed to attempt to remove other round trips as well).
This PR is backwards compatible.
cc @github/database-infrastructure @sjmudd