-
Notifications
You must be signed in to change notification settings - Fork 938
Conversation
…th scheduled to start...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
orchestrator
might run with a SQLite backend, in which case it shouldn't wait on a MySQL server. Even with MySQL backend, it doesn't strictly have to run on same host as MySQL. So unfortunately I cannot merge this.
Just as an idea, how about systemd restarting orchestrator
after failure, in 1min intervals?
Hey @shlomi-noach, This is why I used the From the systemd manual
So I understand this as, this dependency is only enforced whenever both services are scheduled for start... Or do you think I'm interpreting it wrongly? |
Testing output to confirm my assumptions over the config file Installing latest orchestrator on an empty CentOS/7 vagrant machine
Editing the service file to include this patch
Verifying there is no MySQL service present:
Verifying Orchestrator status before testing
Reloading systemd to pick up my change
Copying sample sqlite config and testing orchestrator
|
@mcrauwel thank you! Any thoughts on #229 (comment) ? |
Adding link to my reply to the above mentioned comment. If we agree on moving this PR forward, I will run some extra test to ensure full compatibility on I will then also revert the documentation change that #1012 introduced as this will become obsolete. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's move forward
ubuntu test
installing
editing the service file
checking mysql service
starting
testing mysql service
|
MariaDB test
|
Conclusion:
MariaDB responds to |
this change should cover all bases @shlomi-noach |
Closes #229 |
A Pull Request should be associated with an Issue.
Related issue: #229
Description
Adds a dependency so Orchestrator is only started AFTER MySQL if they are both schedule to start to avoid this behaviour: