Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

add replication delay command #1267

Merged
merged 8 commits into from
Nov 19, 2020

Conversation

marcosvm
Copy link
Contributor

@marcosvm marcosvm commented Nov 16, 2020

Related issue: #1266

Description

This PR adds a command to delay replication on a specific instance keeping the current replication threads status.

Please make sure that:

  • contributed code is using same conventions as original code

Please make sure the PR passes CI tests. For your information, CI tests the following:

  • - code is formatted via gofmt (please avoid goimports)
  • - code passes compilation
  • - code passes unit tests
  • - code passes integration tests with MySQL backend
  • - code passes integration tests with SQLite backend
  • - There are no orphaned docs/ pages (there's some link in the docs to point to any page)
  • - upgrade from previous version (master branch) is successful

Copy link
Collaborator

@shlomi-noach shlomi-noach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This looks good, with a few requests for changes. Please consider adding a delay-replication command in https://github.com/openark/orchestrator/blob/master/resources/bin/orchestrator-client

go/inst/instance_topology_dao.go Show resolved Hide resolved
go/http/api.go Outdated Show resolved Hide resolved
go/inst/instance_topology_dao.go Outdated Show resolved Hide resolved
go/inst/instance_topology_dao.go Show resolved Hide resolved
@marcosvm
Copy link
Contributor Author

@shlomi-noach I added the modifications you suggested. Thank you for the review.

@shlomi-noach shlomi-noach merged commit 8ba9274 into openark:master Nov 19, 2020
@marcosvm marcosvm deleted the marcosvm/deploy-replication branch November 19, 2020 16:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants