This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
ConsulTxnStore: handle failure in read/get transaction #1301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With the exception of #1302 (separate PR to come!) I've confirmed this fixes the majority of the issues found when testing the Ready for @shlomi-noach to review 🙇 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #1300
Description
This PR resolves a panic when the
ConsulTxnStorereturns a nil transaction response due to an error in the transactionFollowing this PR errors in the read transaction (to check existing values) will be logged and will cause the store to perform an update of the keys in the read transaction, as we can't be sure they're consistent if there is a read transaction error
Lastly, this PR adds better unit testing for this issue. Fixes #1300