This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 937
support for force-master-failover command #199
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r into force-master-recovery
For masters: just fail over, or attempt to fail over onto specific instances. No more 'lite' recoveries. People really just want to fail over. For intermediate masters: 'relocate-replicas' instead of match* commands; no 'lite' option
Nice! That's a good interface update, too. |
…r into force-master-recovery
Even better 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the
-c force-master-failover
command.This tells
orchestrator
to assume the master is dead, and that it should kick a full failover, by whatever means it finds necessary to promote a replica.Usage:
or
orchestrator
will figure out what the master is, shut its eyes and make pretend it'sdead
, then kick a failover.Contrast with
force-master-takeover
where the user specifies the replica which must get promoted (more control but potentially more complicated for the user).Note: this PR extends #196
cc @github/database-infrastructure