Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

supporting prefer_not promotion rule #247

Merged
merged 9 commits into from
Aug 9, 2017
Merged

Conversation

shlomi-noach
Copy link
Collaborator

@shlomi-noach shlomi-noach commented Jul 30, 2017

Up till now these promotion rules were supported:

  • prefer: promote if possible
  • neutral
  • must_not: never even participates in promotion process.

We now add prefer_not:

neutral > prefer_not > must_not

A prefer_not server has nothing special about it; it is valid. It contains good data, but we wish not to promote it.

As an example, perhaps this is in particular a weak box, or some AWS box that is heavily used for something else.

However, if a master dies, and such box turns to be most up to date, then by all means we can use it in the promotion flow. For example, we can discretely promote it, let other boxes catch up, then, if promote a prefer box (aka candidate) or even a neutral box on top of it.

So basically it's similar to neutral in essence: nothing special about it, except we'd rather have neutral promoted instead of a prefer_not.

@shlomi-noach shlomi-noach temporarily deployed to production/mysql_cluster=conductor August 6, 2017 07:18 Inactive
@shlomi-noach shlomi-noach temporarily deployed to production/mysql_cluster=conductor August 6, 2017 13:37 Inactive
@shlomi-noach shlomi-noach temporarily deployed to production/mysql_cluster=conductor August 6, 2017 14:28 Inactive
@shlomi-noach shlomi-noach temporarily deployed to production/mysql_cluster=conductor August 7, 2017 04:19 Inactive
@shlomi-noach shlomi-noach temporarily deployed to production/mysql_cluster=conductor August 7, 2017 05:43 Inactive
@shlomi-noach shlomi-noach deployed to production/github-mysqlutil August 7, 2017 05:43 Active
@shlomi-noach shlomi-noach deployed to production/mysql_cluster=mysql6 August 7, 2017 08:35 Active
@shlomi-noach shlomi-noach temporarily deployed to production/mysql_cluster=conductor August 9, 2017 06:17 Inactive
@shlomi-noach shlomi-noach had a problem deploying to production/github-mysqlutil August 9, 2017 06:17 Failure
@shlomi-noach shlomi-noach had a problem deploying to production/mysql_cluster=mysql6 August 9, 2017 06:17 Failure
@shlomi-noach shlomi-noach deployed to production/github-mysqlutil August 9, 2017 06:30 Active
@shlomi-noach shlomi-noach deployed to staging/role=mysqlutil&mysql_cluster=local August 9, 2017 06:31 Active
@shlomi-noach shlomi-noach temporarily deployed to production/mysql_cluster=conductor August 9, 2017 06:31 Inactive
@shlomi-noach shlomi-noach merged commit 3b3ed84 into master Aug 9, 2017
@shlomi-noach shlomi-noach deleted the promotion-rule-prefer-not branch August 9, 2017 10:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants