This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
Faster master recover #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shlomi-noach
temporarily deployed
to
production/mysql_cluster=conductor
shlomi-noach
temporarily deployed
to
production/mysql_cluster=conductor
shlomi-noach
temporarily deployed
to
production/mysql_cluster=conductor
shlomi-noach
temporarily deployed
to
production/mysql_cluster=conductor
shlomi-noach
temporarily deployed
to
production/mysql_cluster=conductor
shlomi-noach
temporarily deployed
to
production/mysql_cluster=conductor
shlomi-noach
temporarily deployed
to
production/mysql_cluster=conductor
shlomi-noach
temporarily deployed
to
production/mysql_cluster=conductor
shlomi-noach
temporarily deployed
to
production/mysql_cluster=conductor
shlomi-noach
temporarily deployed
to
production/mysql_cluster=concertmaster
shlomi-noach
temporarily deployed
to
production/mysql_cluster=concertmaster
shlomi-noach
temporarily deployed
to
production/mysql_cluster=concertmaster
shlomi-noach
temporarily deployed
to
production/mysql_cluster=concertmaster
shlomi-noach
temporarily deployed
to
production/mysql_cluster=concertmaster
shlomi-noach
temporarily deployed
to
production/mysql_cluster=concertmaster
shlomi-noach
temporarily deployed
to
production/mysql_cluster=concertmaster
shlomi-noach
temporarily deployed
to
production/mysql_cluster=concertmaster
shlomi-noach
had a problem deploying
to
production/mysql_cluster=conductor
shlomi-noach
temporarily deployed
to
production/mysql_cluster=concertmaster
shlomi-noach
had a problem deploying
to
production/mysql_cluster=conductor
shlomi-noach
temporarily deployed
to
production/mysql_cluster=concertmaster
shlomi-noach
had a problem deploying
to
production/mysql_cluster=conductor
shlomi-noach
temporarily deployed
to
production/mysql_cluster=conductor
shlomi-noach
temporarily deployed
to
production/mysql_cluster=concertmaster
shlomi-noach
temporarily deployed
to
production/mysql_cluster=conductor
shlomi-noach
temporarily deployed
to
production/mysql_cluster=concertmaster
shlomi-noach
temporarily deployed
to
production/mysql_cluster=concertmaster
shlomi-noach
had a problem deploying
to
production/mysql_cluster=conductor
shlomi-noach
temporarily deployed
to
production/mysql_cluster=conductor
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR optimized master recovery time in calling hooks sonner, and invoking some refactoring asynchronously, under certain conditions.
This change applies at the moment to PseudoGTID-based failovers only. It will follow up to do the same for GTID based failovers.
The idea is that when a master dies, we pick a candidate to promote. If, at that moment, we are able to determine that said candidate is ideal for promotion, we move all topology refactoring to run asychronously, and allow hooks to run immediately.
Implication: hooks, or key-value settings, will run quicker, letting the app speak to the new master sooner, even while
orchestratorwill still be wiring the replicas to replicas from the new master.