This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
UseSuperReadOnly: applying super-read-only #390
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #376
This PR supports
super_read_only
as follows:UseSuperReadOnly
, defaultsfalse
.true
,orchestrator
willset global super_read_only=?
in addition to settingread_only
.super_read_only
only exists in specific MySQL flavors and versions,orchestrator
will not bail out with error when unable toset global super_read_only=?
. Instead, it will only log an error.orchestrator
may also auto-detect whether a server supportssuper_read_only
.