This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
Reducing write overhead of last_attempted_check #432
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reduces the overhead for
last_attempted_check
writes by postponing the write for1sec
. If instance if found by that time, write is cancelled.It is OK that
last_attempted_check
turns to be slightly higher thanlast_checked
even though this chronologically this can't be correct for a successful probe.Write overhead is only reduced when things are generally OK. The optimization is gone away when probing instances consistently takes over
1sec
.