Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

Fix detection of Go 1.10.x #486

Merged
merged 6 commits into from
May 9, 2018
Merged

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented May 6, 2018

Fedora 28 ships with go 1.10.x which build.sh detects as too old, while it isn't too old.
This PR fixes that by a more restrictive regex.

$ go version
go version go1.10.1 linux/amd64

@dveeden
Copy link
Contributor Author

dveeden commented May 6, 2018

Looks like this is a duplicate of #458

@shlomi-noach shlomi-noach self-assigned this May 7, 2018
Copy link
Collaborator

@shlomi-noach shlomi-noach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would need a better method, because the version could be 1.8 or 1.9 (no trailing .).

I have something else in mind, let me push a change.

@shlomi-noach
Copy link
Collaborator

I pushed a change to your PR, and it should be good now: explicitly allowing go1.8, go1.9, go1.10, and anything else is disallowed.

@shlomi-noach shlomi-noach merged commit 2f0f2a7 into openark:master May 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants