Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

check FailMasterPromotionIfSQLThreadNotUpToDate in checkAndRecoverDeadCoMaster #535

Merged
merged 1 commit into from
Jun 25, 2018
Merged

check FailMasterPromotionIfSQLThreadNotUpToDate in checkAndRecoverDeadCoMaster #535

merged 1 commit into from
Jun 25, 2018

Conversation

samiahlroos
Copy link
Contributor

@samiahlroos samiahlroos commented Jun 22, 2018 •
edited by shlomi-noach
Loading

Related issue: #534

Description

This PR adds check for FailMasterPromotionIfSQLThreadNotUpToDate to checkAndRecoverDeadCoMaster function. Same check was added to checkAndRecoverDeadMaster here: #104.

  • contributed code is using same conventions as original code
  • code is formatted via gofmt (please avoid goimports)
  • code is built via ./build.sh
  • code is tested via go test ./go/...

shlomi-noach
shlomi-noach approved these changes Jun 25, 2018
View reviewed changes
Copy link
Collaborator

@shlomi-noach shlomi-noach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@shlomi-noach shlomi-noach self-assigned this Jun 25, 2018
@shlomi-noach shlomi-noach merged commit 7d98476 into openark:master Jun 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shlomi-noach shlomi-noach shlomi-noach approved these changes

Assignees

@shlomi-noach shlomi-noach

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samiahlroos @shlomi-noach