This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
GTID errant transaction detection #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Right now build fails on |
shlomi-noach
temporarily deployed
to
production/mysql_cluster=concertmaster
shlomi-noach
temporarily deployed
to
production/mysql_cluster=concertmaster
|
Errant GTIDs now also show up:
|
shlomi-noach
temporarily deployed
to
production/mysql_cluster=concertmaster
shlomi-noach
temporarily deployed
to
production/mysql_cluster=concertmaster
shlomi-noach
temporarily deployed
to
production/mysql_cluster=concertmaster
shlomi-noach
temporarily deployed
to
production/mysql_cluster=concertmaster
shlomi-noach
temporarily deployed
to
production/mysql_cluster=conductor
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR
orchestratorauto-analyzes errant transactions for GTID-based replicas.At this time it does nothing about it, merely presents it in the web UI.
Heuristic for avoiding false positives
orchestratorpolls different servers at different times. It may be that it first polled the master and then its replica. In such case, the replica will naturally be seen to have more entries than the master.If the replica also happens to have real errant transactions, how can we tell apart the two?
orchestratorignores the GTID set that relates to the replica's immediate master UUID. At this timeorchestratordoes not further ignore upstream UUIDs, and this is TBD.This PR is to be considered as POC.
In future PRs
orchestratorwill allow the user to fix errant transactions across the cluster, in a click of a button, or via command line. To be carefully thought of.