Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

consolidate detach-replica and detach-replica-master-host #801

Merged
merged 6 commits into from
Feb 20, 2019

Conversation

shlomi-noach
Copy link
Collaborator

Fixes #779

This PR consolidates detach-replica and detach-replica-master-host. It makes detach-replica behave exactly like detach-replica-master-host. This makes detach-replica safe to work with GTIDs. See #779 for more details.

@ggunson
Copy link
Contributor

ggunson commented Feb 10, 2019

What specifically does detach-replica-master-host do that detach-replica doesn't?

@shlomi-noach
Copy link
Collaborator Author

shlomi-noach commented Feb 11, 2019

detach-replica-master-host changes the master hostname from some.host.name.com to //some.host.name.com.

detach-replica (before this PR) changes Master_log_file from mysql-bin.0001234 to //mysql-bin.0001234:29043857. This worked well for non-GTID setups, but for AUTO_POSITION=1 it would error.

The advantage of the detach-replica approach is that the replica still points to the same master, just unable to replicate.

@shlomi-noach shlomi-noach temporarily deployed to production/mysql_cluster=conductor February 12, 2019 04:58 Inactive
@shlomi-noach shlomi-noach had a problem deploying to production/mysql_cluster=conductor February 13, 2019 12:56 Failure
@shlomi-noach shlomi-noach temporarily deployed to production/mysql_cluster=conductor February 13, 2019 12:59 Inactive
@shlomi-noach shlomi-noach changed the title Detach replica consolidate consolidate detach-replica and detach-replica-master-host Feb 13, 2019
@shlomi-noach shlomi-noach temporarily deployed to production/mysql_cluster=conductor February 14, 2019 11:02 Inactive
@shlomi-noach shlomi-noach merged commit 22f6814 into master Feb 20, 2019
@shlomi-noach shlomi-noach deleted the detach-replica-consolidate branch February 20, 2019 07:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants