Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

adding bash to final container so examples work #805

Merged
merged 2 commits into from
Feb 21, 2019

Conversation

anthonyneto
Copy link
Contributor

@anthonyneto anthonyneto commented Feb 13, 2019

Examples from the documentation use echo however echo cannot be used without bash. resolves #783

Whenever an event happens that uses a hook to shell out I would get this error.

Copy link
Collaborator

@shlomi-noach shlomi-noach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Good catch

@shlomi-noach shlomi-noach self-assigned this Feb 14, 2019
FROM alpine:3.6
FROM alpine:3.8

RUN apk add --no-cache bash
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wondering: why --no-cache for bash?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This avoids the need to use --update and remove /var/cache/apk/* when done installing packages.

@shlomi-noach shlomi-noach merged commit 172cec8 into openark:master Feb 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bash missing from Dockerfile
2 participants