Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(shell): Add battery function #113

Merged
merged 1 commit into from
May 6, 2024
Merged

Conversation

Xiaojun0822
Copy link
Contributor

Add battery function to obtain battery status

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 36.36364% with 35 lines in your changes are missing coverage. Please review.

Project coverage is 26.66%. Comparing base (fe3aa9c) to head (dcf1bc6).
Report is 2 commits behind head on master.

Files Patch % Lines
adbutils/shell.py 5.40% 35 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #113      +/-   ##
==========================================
+ Coverage   26.40%   26.66%   +0.25%     
==========================================
  Files          15       15              
  Lines        1916     1969      +53     
  Branches      311      314       +3     
==========================================
+ Hits          506      525      +19     
- Misses       1399     1433      +34     
  Partials       11       11              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codeskyblue
Copy link
Member

It looks fine almost. Unit test should add into tests/

@Xiaojun0822
Copy link
Contributor Author

It looks fine almost. Unit test should add into tests/

I see that the unit tests for the ShellExtension are all in test-real_device/test_device. py. Please confirm that only the battery is added into tests/ ?

@codeskyblue codeskyblue merged commit 2410806 into openatx:master May 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants