Add support for running in a build.gradle that is run from a GradleBuildTask (i.e. subproject) #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide the project directory to the command runner when calling xcodebuild. It doesn't assume gradle is run from the same directory as the one containing the build.gradle containing the xcodebuild task. This is useful when you want to call the xcode build.gradle as a GradleBuildTask from a master build script.
…ebuild. It doesn't assume gradle is run from the same directory as the one containing the build.gradle containing the xcodebuild task. This is useful when you want to call the xcode build.gradle as a GradleBuildTask from a master build script.
…oject plist It doesn't assume gradle is run from the same directory as the one containing the build.gradle containing the AbstractXCodeTask. This is useful when you want to call the plist-modify task in a build.gradle as a GradleBuildTask from a master build script.
renep
added a commit
that referenced
this pull request
Aug 19, 2013
renep
added a commit
that referenced
this pull request
Aug 19, 2013
|
I have merged your request into the master and have created a new version 0.8.6 that includes your changes. I have done this manually, because you have changed the indentation in your changed to use spaces. This project uses tabs. e.g. you have changed only one line in AbstractXcodeTask.groovy, but in your pull requests the whole file has changed. The second thing I have changed from your code is, that I have removed the ${File.separator} and changed it back to /. The plugin will only work on OS X, so I do not need to windows support. I prefer using / because it makes the code easier to read. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change is to pass the project directory to the commandRunner when calling xcodeBuild.
This means that the xcode task can be in a build.gradle that is in a project subfolder (along with the xoce project files), and can be called from a master build.gradle
Also added support for running the plugin test from a windows box (not assuming '/' as the file separator)