Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added -project parameter for xcodebuild #451

Merged
merged 3 commits into from
May 10, 2022
Merged

Conversation

amattil1
Copy link
Contributor

When having 2 .xcodeproj files in same directory, xcode plugin fails when xcodebuild command is being executed. This is fixed by passing -project option for xcodebuild command.

@renep
Copy link
Contributor

renep commented Feb 16, 2022

Thanks for the pull request.
I have review your changes and have not seen any unit test for your change. As you find in the collobaration section at the Readme you will find the info, that I will not merge pull requests that does not contain unit tests.
As soon as you add proper unit tests for your changes, I will merge this pull request.

@amattil1
Copy link
Contributor Author

amattil1 commented May 9, 2022

Added test for -project parameter.

@amattil1
Copy link
Contributor Author

Any changes to merge the pull request? We would have use for this right away. Using CMake with Xcode, the project will be generated to different folder than where build.gradle resides. xcodeplugin wants the project to exist in same folder which means that cmake needs to generate the build files to same folder as all the other project files, thus writing lot of garbage in the folder and making clean call hard. Also requires lots of svn/git ignore files for cmake temp files. Very messy. With this -project switch I can point the xcodeproj file from subdirectory, and it would all be fine and dandy :) Thanks.

@renep
Copy link
Contributor

renep commented May 10, 2022

Normally I only merge pull request that are on the develop branch. But I think (and hope) that this changes does not break anything. Lets see.

@renep renep merged commit daecc55 into openbakery:main May 10, 2022
@renep
Copy link
Contributor

renep commented May 10, 2022

There is now a 0.22.2 version with your change.

@amattil1
Copy link
Contributor Author

Awesome, thank you! Seems to work as it should. 👍

Only strange thing is that I cannot directly reference the version 0.22.2, I have to use 0.22.+ in build.gradle. I have maven url https://openbakery.org/repository/ and dependencies defined with classpath group: 'org.openbakery', name: 'xcode-plugin', version: '0.22.2' .. result is "Could not find org.openbakery:xcode-plugin:0.22.2."

Any idea why I need to use + instead of 2?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants