Investigating mysterious Docker errors #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No spelling errors! 🎉 |
|
This fixes it! Basically I didn't realize that the docker github actions use the container specified as the global docker image for the action so it looked for docker to be installed on that image which it is not. To get around this we just have to return to the original method of specifying |
|
I will be making these changes upstream on the OTTR_Template repo as well. |
|
still confused as to why the OCSdata package isn't getting recognized |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose/implementation Section
What changes are being implemented in this Pull Request?
Investigating the Docker login works in Docker test github action yml: https://github.com/opencasestudies/OCS_Guide/actions/runs/1786353460
But isn't working in the render-bookdown.yml: https://github.com/opencasestudies/OCS_Guide/runs/5045929531?check_suite_focus=true
Only difference I can see so far is that the order of the steps are different (this shouldn't affect it but let's see)