Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Player settings ends up throwing error on fresh installation #177

Closed
ferishili opened this issue Jul 3, 2023 · 1 comment
Closed

Player settings ends up throwing error on fresh installation #177

ferishili opened this issue Jul 3, 2023 · 1 comment
Labels
bug Something isn't working Priority: Medium Needs to be fixed/taken care of in the next few month

Comments

@ferishili
Copy link
Contributor

Description

When installing a fresh instance (v5.1.1 - ILIAS 7), the Player settings tab in plugin configuration throws error and won't open.

To Reproduce
Steps to reproduce the behavior:

  1. Fresh install (v5.1.1) version on ILIAS 7
  2. Activate plugin and go to configure
  3. Navigate to Settings > Player
  4. See error

Culprit
src/UI/PaellaConfig/PaellaConfigFormBuilder.php:

Line 62: PluginConfig::getConfig(PluginConfig::F_PAELLA_OPTION)

Line 67: PluginConfig::getConfig(PluginConfig::F_PAELLA_OPTION_LIVE)

Solution
Since F_PAELLA_OPTION and F_PAELLA_OPTION_LIVE both must have the value 'default' initially, why not adding them in the code like:

  • PluginConfig::getConfig(PluginConfig::F_PAELLA_OPTION) ?? 'default'
  • PluginConfig::getConfig(PluginConfig::F_PAELLA_OPTION_LIVE) ?? 'default'

Expected behavior
The Player tab on a fresh installation has to be accessible no matter what!

Environment (please complete the following information):

  • ILIAS version: release_7
  • PHP version: 7.4.3
  • Plugin version: 5.1.1
  • Opencast version 13.5
  • Browser: firefox
@ferishili ferishili added the bug Something isn't working label Jul 3, 2023
@dagraf dagraf added the Priority: Medium Needs to be fixed/taken care of in the next few month label Jul 3, 2023
@ferishili ferishili mentioned this issue Jul 4, 2023
Closed
@ferishili ferishili mentioned this issue Jul 26, 2023
Closed
@dagraf
Copy link

dagraf commented Sep 5, 2023

Fixed with #186

@dagraf dagraf closed this as completed Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Priority: Medium Needs to be fixed/taken care of in the next few month
Projects
None yet
Milestone
No milestone
2 participants
@dagraf @ferishili