Fix/7/remove dictrait & Opencast PHP Library integration #186
Conversation
# Conflicts: # classes/Event/class.xoctEventGUI.php # classes/Event/class.xoctEventTableGUI.php # classes/Request/class.xoctCurl.php # classes/Request/class.xoctCurlSettings.php # classes/class.ilObjOpenCastAccess.php
…into srsolutionsag-oc-php-lib
|
@dagraf i suggest to create issues with a new label „testing0822“ or something similar. additionally as @ferishili mentioned, we will push fixes tho this branch as well, therefore you should update the code on your testing installation maybe daily or more often if possible |
|
@ferishili and @chfsx: I will continue with testing (and probably finish it) on thursday. So I would suggest you push as many fixes as possible untill tomorrow evening and then let me test this version on thursday. How does this sound? |
|
@dagraf perfect, thanks in advance for testing! |
|
I done with testing and detected only 2 issues (see bug reports). Unfortunately, I was not able to test our Tobira and Annotation Tool test cases because those are not installed on our Opencast we run for the community. As soon as we are finished testing other features on our other test installations we will test those cases. This will be not before the end of next week. |
|
I'm done with testing this PR and the bugfixes I could do on our community ILIAS connected to the community Opencast. What I could not test: annotation tool, Tobira connection, access granting via API, Live-Streaming |
|
@dagraf Thanks for the testing and feedback! I also think that we can merge the PR now and release a new version afterwards. But iahc would wait with the renaming of the branch until we then also publish an ILIAS 8 version. From then on it makes sense to name the branches according to the ILIAS releases (release_7, release_8, ...). Is that ok? |
|
@chfsx Yes, sounds good. Thanks! |
|
@chfsx Could you merge this PR before our next community meeting tomorrow? |
|
@dagraf I will make a new release before the meeting tomorrow 👍 |
This PR contains 2 major parts including PR #184 and Opencast PHP Library integration. Therefore it closes #184 in favor of following upcoming related changes here.
It is a development-collaboration between @chfsx and @ferishili!
Testing
As it is considered as a major refactoring/integration change and affects almost everything, this PR needs a in-depth testing! (please refer to Suggestion beforehand)
Suggestion
It is recommended to apply PR #180, before this PR, in order to make it work seamlessly also in fresh installations!
Resolution
This PR fixes #187, due to the fact that DICTrait is now removed