Fix/7/remove dictrait #184
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # classes/Event/class.xoctEventGUI.php # classes/Event/class.xoctEventTableGUI.php # classes/Request/class.xoctCurl.php # classes/Request/class.xoctCurlSettings.php # classes/class.ilObjOpenCastAccess.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is a first step to optimize the plugin for future maintenance. The goal is to get rid of all vendor/srag dependencies.
A very common use was the DICTrait, a collection of static methods for all possible dependencies. With this PR the DICTrait is removed from all classes. This means that practically every class has been changed.
Furthermore, all possible errors of the Inspection Profile for PHP8 have been removed (see #172, which becomes obsolete). I also did a lot of general code optimizations, some of them automatic with Rector (see https://github.com/rectorphp/rector).
I was able to test the changes so far that all GUI are still callable and I could successfully create e.g. new DSeries. However, this PR requires intensive testing.
I would like to start all further modifications on this basis, because this way some problems can be solved, which would stop us anyway, e.g. with ILIAS 8 support.