Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opencast PHP Library upgrade to v1.5.0 #218

Closed
wants to merge 2 commits into from

Conversation

ferishili
Copy link
Contributor

This PR only upgrades the Opencast PHP Library to the latest version (v.1.5.0) which contains PHP 8.2 compatibility improvement: deprecated dynamic property declaration

@ferishili ferishili requested a review from chfsx November 15, 2023 14:27
@ferishili ferishili self-assigned this Nov 15, 2023
@ferishili ferishili added the Priority: High Needs to be fixed/taken care of asap label Nov 15, 2023
@dagraf
Copy link

dagraf commented Nov 16, 2023

@ferishili: Thank you for this PR. Does it need testing of (any) functionalities?

@ferishili
Copy link
Contributor Author

ferishili commented Nov 16, 2023

No problem, a normal plain test of just refreshing the event lists and or updating metdata would be very helpful and enough

@ferishili
Copy link
Contributor Author

I just encountered an error during upload with ingest! let me look into it

Copy link
Contributor

@chfsx chfsx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot!

@dagraf
Copy link

dagraf commented Nov 20, 2023

I did the recommended plain test of refreshing the event list and updated some metadata. Both work as expected.

Therefore and @Amstutz: Can you please review this PR and comment it if needed or merge it. Thx!

@chfsx
Copy link
Contributor

chfsx commented Nov 21, 2023

Plugin-version should be increased after merging this PR

@chfsx chfsx assigned chfsx and unassigned ferishili Nov 23, 2023
chfsx added a commit to srsolutionsag/OpenCast that referenced this pull request Nov 23, 2023
commit f4a44a9
Author: ferishili <zamanifarbod2@gmail.com>
Date:   Thu Nov 16 14:50:52 2023 +0100

    fix: activating ingest service properly

commit b6f58fa
Author: ferishili <zamanifarbod2@gmail.com>
Date:   Thu Nov 16 09:05:42 2023 +0100

    upgrade oc-php-lib to v1.5.0: php8.2 compat.
@chfsx chfsx mentioned this pull request Nov 23, 2023
chfsx added a commit that referenced this pull request Nov 23, 2023
commit f4a44a9
Author: ferishili <zamanifarbod2@gmail.com>
Date:   Thu Nov 16 14:50:52 2023 +0100

    fix: activating ingest service properly

commit b6f58fa
Author: ferishili <zamanifarbod2@gmail.com>
Date:   Thu Nov 16 09:05:42 2023 +0100

    upgrade oc-php-lib to v1.5.0: php8.2 compat.
@chfsx
Copy link
Contributor

chfsx commented Nov 23, 2023

Merged using #230

@chfsx chfsx closed this Nov 23, 2023
okaufman added a commit to ilub-unibe-ch/OpenCast that referenced this pull request Nov 28, 2023
* main: (92 commits)
  using LocaleTrait everywhere needed + docs
  fix: Processing stdClass/null error
  Increased Plugin version
  [FIX] 212: The status of "Publish Series on VIDEOPORTAL" does not get saved
  New Plugin Version and Changelog
  Rebuilt JS after merge
  Merged PR opencast-ilias#208: New Publication Usages (Sub-usage & groups)
  Merged PR opencast-ilias#218
  squashing dependabot bumps
  Restored JS for chat
  Removed Old Node Modules
  Updated Node-Modules and removed legacy paella player
  Bump engine.io and socket.io
  Bump socket.io-parser from 4.2.1 to 4.2.3
  Bump semver from 7.3.5 to 7.5.4
  [FIX] Interface of VoidContainer
  Updated Changelog
  [FIX] added check for APCu installed in form
  Added Readme for Cache
  [FIX] implemented new caching service and removed non working legacy service
  ...

# Conflicts:
#	js/paella_player/config.json
#	js/paella_player/config_live.json
#	src/Chat/GUI/open_chat.php
#	src/Model/Event/EventAPIRepository.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: High Needs to be fixed/taken care of asap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants