Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Memory Limit Issue with large files to upload #221

Merged
merged 3 commits into from
Nov 21, 2023

Conversation

chfsx
Copy link
Contributor

@chfsx chfsx commented Nov 20, 2023

This fixes the memory limit issue in #220

@reiferschris
Copy link
Contributor

I did a test with a 2GB file and the upload worked.
The "save"-Button however was not disabled immediately like before. The "spinner" animation that previously block any more user interaction only showed up briefly, when the process was almost done.

@dagraf
Copy link

dagraf commented Nov 20, 2023

@marcusm7: Did you make the same observation as @reiferschris ("Save"-Button does not get disabled immediately when clicking on "Save") during your tests?

@marcusm7
Copy link

#220 (comment)

In my case the 'Speichern' button is disabled until the upload of the 10G file is completed (as before). After click on 'Speichern' the spinner animation is shown until the ingest is completed (as far as I can tell,the spinner-animation was there for a some seconds, while the fpm-worker generated some cpu load.). But I don't want to contradict @reiferschris - I just did a very quick test.

@dagraf
Copy link

dagraf commented Nov 20, 2023

I make the same observation as described here (#221 (comment)). But the same is true for the plugin v5.1.1 that is running on our productive ILIAS. Therefore and @chfsx: Could you please have a short look into it if there would be a quick solution to disable user interactions as soon as a user hits on "Save"? Thank you.

@chfsx
Copy link
Contributor Author

chfsx commented Nov 21, 2023

Thank you for testing! yes, the overlay was not displayed at the right time before. i have now implemented this, rebuilt the JavaScript for the overlay and made some optimizations for the future.

@chfsx chfsx mentioned this pull request Nov 21, 2023
@chfsx
Copy link
Contributor Author

chfsx commented Nov 21, 2023

The PR updates the plugin to version 5.3.2

@dagraf
Copy link

dagraf commented Nov 21, 2023

Thx for the update. I can confirm that the spinning wheel overlay gets displayed right after clicking on "Save" and that upload of large files works now.

Therefore, and @Amstutz: Can you please review this PR and comment it if needed or merge it? Thx!

@Amstutz
Copy link
Contributor

Amstutz commented Nov 21, 2023

Thx for removing the static functions and for adding the JS class!

@Amstutz Amstutz merged commit b67a7c6 into opencast-ilias:main Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants