-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Memory Limit Issue with large files to upload #221
Conversation
I did a test with a 2GB file and the upload worked. |
@marcusm7: Did you make the same observation as @reiferschris ("Save"-Button does not get disabled immediately when clicking on "Save") during your tests? |
In my case the 'Speichern' button is disabled until the upload of the 10G file is completed (as before). After click on 'Speichern' the spinner animation is shown until the ingest is completed (as far as I can tell,the spinner-animation was there for a some seconds, while the fpm-worker generated some cpu load.). But I don't want to contradict @reiferschris - I just did a very quick test. |
I make the same observation as described here (#221 (comment)). But the same is true for the plugin v5.1.1 that is running on our productive ILIAS. Therefore and @chfsx: Could you please have a short look into it if there would be a quick solution to disable user interactions as soon as a user hits on "Save"? Thank you. |
Thank you for testing! yes, the overlay was not displayed at the right time before. i have now implemented this, rebuilt the JavaScript for the overlay and made some optimizations for the future. |
The PR updates the plugin to version 5.3.2 |
Thx for the update. I can confirm that the spinning wheel overlay gets displayed right after clicking on "Save" and that upload of large files works now. Therefore, and @Amstutz: Can you please review this PR and comment it if needed or merge it? Thx! |
Thx for removing the static functions and for adding the JS class! |
This fixes the memory limit issue in #220