(1/3) Merge questionnaire into master #603
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`label.category` is only set for preexisting categories, not for ones created during the current browser session.
With this patch, the frontend also knows about deleted labels, categories, scales and scale values. This makes the behavior of annotations carrying any of that deleted structure much more consistent.
Previously it already showed the editing interface for the scale of the category you got to the dialog with. It wasn't fully in edit mode yet, though, so edits could get lost.
There were two functionally very similar `findById` functions. Now there is only one.
Minimum version is now Opencast 13.
Apparently if you set parameters on a namedQuery directly, there are some shenanigans that can happen when it comes to dates. Opencast has a function called `configureQuery` https://github.com/opencast/opencast/blob/develop/modules/common/src/main/java/org/opencastproject/db/Queries.java#L58 to handle this, but does not grant anyone access to it. In my plight I just copied it over.
…g our own. Co-authored-by: Julian Kniephoff <me@juliankniephoff.com>
Make every caller pass their preferred type instead of doing a cast.
Co-authored-by: Julian Kniephoff <me@juliankniephoff.com>
Co-authored-by: Julian Kniephoff <me@juliankniephoff.com>
Fix db compatibility issues with Opencast 13
* Minimally improve the formatting * Remove useless settings
Update `h2`
Revert "Update `h2`"
* Minimally improve the formatting * Remove useless settings
That `when` was in the wrong place.
This makes the tests work with newer Java versions (tested with 20) and also fixes a warning about invalid POMs during the Maven build.
When building with Maven's `-T` option the build was warning about two plugins that might not be thread safe. This patch updates one and removes the other. Regarding static weaving: It might be interesting to look at at some point, but it's "only" for performance and Opencast removed this as well: opencast/opencast#3031.
Also some minor nitpicks and fixing of lints.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merged the branches that have diverged over 1+ year.