Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK-7134 - Re-implement Aggregations Stats for all Catalog Browsers #100

Merged
merged 53 commits into from
Feb 10, 2025

Conversation

jtarraga
Copy link
Member

Re-implement Aggregations Stats for all Catalog Browsers

@jtarraga jtarraga requested a review from pfurio November 12, 2024 10:16
@imedina
Copy link
Member

imedina commented Nov 12, 2024

pfurio
pfurio previously approved these changes Nov 12, 2024
if (queryResultWriter != null) {
try {
queryResultWriter.open();
if (operations != null && operations.size() > 0) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use CollectionUtils.isNotEmpty() ??

@jtarraga jtarraga requested a review from pfurio November 13, 2024 12:15
@jtarraga jtarraga changed the title Task 7134 - Re-implement Aggregations Stats for all Catalog Browsers TASK-7134 - Re-implement Aggregations Stats for all Catalog Browsers Nov 13, 2024
pfurio
pfurio previously approved these changes Nov 13, 2024
@jtarraga jtarraga requested a review from pfurio February 3, 2025 10:49
pfurio
pfurio previously approved these changes Feb 3, 2025
pfurio
pfurio previously approved these changes Feb 4, 2025
@jtarraga jtarraga requested a review from pfurio February 6, 2025 12:29
pfurio
pfurio previously approved these changes Feb 6, 2025
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this doesn't need to be merged

@jtarraga jtarraga merged commit b2a79c7 into develop Feb 10, 2025
6 of 7 checks passed
@jtarraga jtarraga deleted the TASK-7134 branch February 10, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants