Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Normalize composer.json #1085

Merged
merged 3 commits into from
Feb 28, 2018
Merged

Enhancement: Normalize composer.json #1085

merged 3 commits into from
Feb 28, 2018

Conversation

localheinz
Copy link
Contributor

@localheinz localheinz commented Jan 20, 2018 •
edited
Loading

This PR

  • requires localheinz/composer-normalize
  • runs composer normalize --dry-run on Travis
  • normalizes composer.json

💁‍♂️ For reference, see

@derrabus
Copy link
Contributor

If we take that road, I'd suggest to make sure that composer files remain normalized. I have opened a feature request ergebnis/composer-normalize#29 for that purpose.

@localheinz
Copy link
Contributor Author

@derrabus

Because of ergebnis/composer-normalize#30 I require php:^7.1, so for now we can't use localheinz/composer-normalize as a direct development dependency, unless we drop support for PHP 7.0.

@derrabus
Copy link
Contributor

@localheinz I see. But you could do the validation on the php 7.1 Travis run only.

@localheinz localheinz removed the request for review from mdwheele February 28, 2018 15:54
@localheinz localheinz assigned localheinz and unassigned mdwheele Feb 28, 2018
@localheinz localheinz assigned chartjes and unassigned localheinz Feb 28, 2018
chartjes
chartjes approved these changes Feb 28, 2018
View reviewed changes
Copy link
Contributor

@chartjes chartjes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@chartjes
Copy link
Contributor

Thanks @localheinz and @derrabus

@chartjes chartjes merged commit 4259bfe into opencfp:master Feb 28, 2018
@localheinz localheinz deleted the feature/normalize branch February 28, 2018 16:49
@localheinz
Copy link
Contributor Author

Thank you, @chartjes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chartjes chartjes chartjes approved these changes

Assignees

@chartjes chartjes

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@localheinz @derrabus @chartjes @mdwheele