Skip bills with restricted view #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hancush
reviewed
Oct 17, 2018
| # If this Boolean field is True, then do not scrape the Bill. | ||
| # This issue explains why a restricted Bill might appear (unwelcome) in the Legistar API: | ||
| # https://github.com/datamade/la-metro-councilmatic/issues/345#issuecomment-421184826 | ||
| if matter['MatterRestrictViewViaWeb']: |
There was a problem hiding this comment.
is this always true or false and not none?
There was a problem hiding this comment.
The Legistar docs describe it as a boolean: http://webapi.legistar.com/Help/Api/PUT-v1-Client-Matters-MatterId A boolean, I believe, can be null, but that does not seem possible in this case, since the value of MatterRestrictViewViaWeb is determined Metro staff checking a box. That is, if the box is checked, then the value is true, and if the box is unchecked, then the value is false.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR handles the first condition described here Metro-Records/la-metro-councilmatic#345 (comment).