Switch DELETE requests to 200 instead of 204 response code

204 means no body, but we're returning a success message. This causes echo server to print an error in the logs and the body gets dropped.
openclarity · Mar 19, 2023 · 06c5a00 · 06c5a00
1 parent 0605e2d
commit 06c5a00
Show file tree

Hide file tree

Showing 7 changed files with 34 additions and 34 deletions.
diff --git a/api/client/client.gen.go b/api/client/client.gen.go
diff --git a/api/openapi.yaml b/api/openapi.yaml
@@ -106,7 +106,7 @@ paths:
       parameters:
         - $ref: '#/components/parameters/targetID'
       responses:
-        204:
+        200:
           $ref: '#/components/responses/Success'
         404:
           description: Target ID not found
@@ -362,7 +362,7 @@ paths:
       parameters:
         - $ref: '#/components/parameters/scanID'
       responses:
-        204:
+        200:
           $ref: '#/components/responses/Success'
         404:
           description: Scan ID not found
@@ -498,7 +498,7 @@ paths:
       parameters:
         - $ref: '#/components/parameters/scanConfigID'
       responses:
-        204:
+        200:
           $ref: '#/components/responses/Success'
         404:
           description: Scan config ID not found
@@ -668,7 +668,7 @@ paths:
       parameters:
         - $ref: '#/components/parameters/findingID'
       responses:
-        204:
+        200:
           $ref: '#/components/responses/Success'
         404:
           description: Finding ID not found

diff --git a/api/server/server.gen.go b/api/server/server.gen.go
diff --git a/backend/pkg/rest/findings_controller.go b/backend/pkg/rest/findings_controller.go
@@ -82,7 +82,7 @@ func (s *ServerImpl) DeleteFindingsFindingID(ctx echo.Context, findingID models.
 		return sendError(ctx, http.StatusInternalServerError, err.Error())
 	}
 
-	return sendResponse(ctx, http.StatusNoContent, &success)
+	return sendResponse(ctx, http.StatusOK, &success)
 }
 
 func (s *ServerImpl) PatchFindingsFindingID(ctx echo.Context, findingID models.FindingID) error {

diff --git a/backend/pkg/rest/scan_config_controller.go b/backend/pkg/rest/scan_config_controller.go
@@ -82,7 +82,7 @@ func (s *ServerImpl) DeleteScanConfigsScanConfigID(ctx echo.Context, scanConfigI
 		return sendError(ctx, http.StatusInternalServerError, err.Error())
 	}
 
-	return sendResponse(ctx, http.StatusNoContent, &success)
+	return sendResponse(ctx, http.StatusOK, &success)
 }
 
 func (s *ServerImpl) PatchScanConfigsScanConfigID(ctx echo.Context, scanConfigID models.ScanConfigID) error {

diff --git a/backend/pkg/rest/scan_controller.go b/backend/pkg/rest/scan_controller.go
@@ -72,7 +72,7 @@ func (s *ServerImpl) DeleteScansScanID(ctx echo.Context, scanID models.ScanID) e
 		return sendError(ctx, http.StatusInternalServerError, fmt.Sprintf("failed to delete scan from db. scanID=%v: %v", scanID, err))
 	}
 
-	return sendResponse(ctx, http.StatusNoContent, &success)
+	return sendResponse(ctx, http.StatusOK, &success)
 }
 
 func (s *ServerImpl) GetScansScanID(ctx echo.Context, scanID models.ScanID, params models.GetScansScanIDParams) error {

diff --git a/backend/pkg/rest/target_controller.go b/backend/pkg/rest/target_controller.go
@@ -110,5 +110,5 @@ func (s *ServerImpl) DeleteTargetsTargetID(ctx echo.Context, targetID models.Tar
 		return sendError(ctx, http.StatusInternalServerError, fmt.Sprintf("failed to delete target from db. targetID=%v: %v", targetID, err))
 	}
 
-	return sendResponse(ctx, http.StatusNoContent, &success)
+	return sendResponse(ctx, http.StatusOK, &success)
 }