Skip to content

Commit

Permalink
fix: subst spaces with commas in GO_BUILD_TAGS
Browse files Browse the repository at this point in the history
Signed-off-by: András Jáky <ajaky@cisco.com>
  • Loading branch information
akijakya committed Mar 3, 2024
1 parent 34de0b6 commit 69507ad
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ build: ui build-all-go ## Build all components
build-all-go: bin/vmclarity-apiserver bin/vmclarity-cli bin/vmclarity-orchestrator bin/vmclarity-ui-backend bin/vmclarity-cr-discovery-server ## Build all go components

BUILD_OPTS = -race
BUILD_OPTS += -tags="$(GO_BUILD_TAGS)"
BUILD_OPTS += -tags=$(call subst-space-with-comma,$(GO_BUILD_TAGS))

LDFLAGS = -s -w
LDFLAGS += -X 'github.com/openclarity/vmclarity/core/version.Version=$(VERSION)'
Expand Down Expand Up @@ -494,3 +494,9 @@ endif

$(DIST_DIR)/CHANGELOG.md: $(ROOT_DIR)/cliff.toml bin/git-cliff | $(DIST_DIR)
$(GITCLIFF_BIN) --config $(ROOT_DIR)/cliff.toml --output $@ $(GITCLIFF_OPTS)

# helper to create a comma separated list from a space separated list
null :=
space := $(null) #
comma := ,
subst-space-with-comma = $(subst $(space),$(comma),$(strip $(1)))

0 comments on commit 69507ad

Please sign in to comment.