Add VmClarity cloud-formation starting point #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
vmclarity_cloud_formation
branch
2 times, most recently
from
73a26e7
to
5ee3e7b
Compare
Adds a cloud-formation manifest which creates a VPC, Network and RBAC for the VMClarity backend. It spins up a generic ubuntu VM which notifies cloud formation when its ready.
The vmclarity systemd unit will configure and start the VMClarity backend container. It will watch the status and restart it, if it stops for whatever reason. The container it starts right now is a generic ubuntu container until we've got a VMClarity backend container published.
ghost
force-pushed
the
vmclarity_cloud_formation
branch
from
5ee3e7b
to
3ea303e
Compare
FrimIdan
reviewed
Nov 16, 2022
akpsgit
approved these changes
Nov 16, 2022
FrimIdan
reviewed
Nov 16, 2022
Comment on lines
+161
to
+164
| - IpProtocol: tcp | ||
| FromPort: 80 | ||
| ToPort: 80 | ||
| CidrIp: 0.0.0.0/0 |
There was a problem hiding this comment.
Will address in the follow up task
Comment on lines
+215
to
+229
| - "ec2:DetachVolume" | ||
| - "ec2:AttachVolume" | ||
| - "ec2:ExportImage" | ||
| - "ec2:TerminateInstances" | ||
| - "ec2:DeleteTags" | ||
| - "ec2:CreateTags" | ||
| - "ec2:RunInstances" | ||
| - "ec2:StopInstances" | ||
| - "ec2:DescribeVolumeAttribute" | ||
| - "ec2:CreateVolume" | ||
| - "ec2:DescribeStoreImageTasks" | ||
| - "ec2:DeleteVolume" | ||
| - "ec2:StartInstances" | ||
| - "ec2:CreateSnapshots" | ||
| - "ec2:CreateSnapshot" |
There was a problem hiding this comment.
separate (with a comment for now even) permissions needed for the entire account and only for our VPC
There was a problem hiding this comment.
Will address in the follow up task
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.