Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ui): switch to vite for building and bundling #1012

Merged
merged 4 commits into from
Dec 7, 2023
Merged

refactor(ui): switch to vite for building and bundling #1012

merged 4 commits into from
Dec 7, 2023

Conversation

gallotamas
Copy link
Contributor

@gallotamas gallotamas commented Dec 6, 2023 •
edited

Description

Remove CRA (Create React App) and use vite for building and bundling. See #934 for detailed description.

It should solve this dependabot alert as well: https://github.com/openclarity/vmclarity/security/dependabot/45

Type of Change

[ ] Bug Fix
[ ] New Feature
[ ] Breaking Change
[x] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@gallotamas gallotamas requested a review from a team as a code owner December 6, 2023 13:41
@gallotamas gallotamas changed the title Switch to vite refactor(ui): switch to vite for building and bundling Dec 6, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2023

Hey!

Your images are ready:

  • ghcr.io/openclarity/vmclarity-apiserver-dev:pr1012-d25afc8a1bacc649a0e4eb3a0052a5411a847aba
  • ghcr.io/openclarity/vmclarity-orchestrator-dev:pr1012-d25afc8a1bacc649a0e4eb3a0052a5411a847aba
  • ghcr.io/openclarity/vmclarity-ui-backend-dev:pr1012-d25afc8a1bacc649a0e4eb3a0052a5411a847aba
  • ghcr.io/openclarity/vmclarity-ui-dev:pr1012-d25afc8a1bacc649a0e4eb3a0052a5411a847aba
  • ghcr.io/openclarity/vmclarity-cli-dev:pr1012-d25afc8a1bacc649a0e4eb3a0052a5411a847aba

@chrisgacsal chrisgacsal added enhancement New feature or request component:ui Issues related to UI/Frontend labels Dec 6, 2023
chrisgacsal
chrisgacsal approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@chrisgacsal chrisgacsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! Thanks a lot! 🚀

@gallotamas gallotamas added this pull request to the merge queue Dec 7, 2023
Merged via the queue into main with commit 91c90be Dec 7, 2023
34 checks passed
@gallotamas gallotamas deleted the switch-to-vite branch December 7, 2023 13:51
@gallotamas gallotamas mentioned this pull request Dec 7, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisgacsal chrisgacsal chrisgacsal approved these changes

@adamtagscherer adamtagscherer adamtagscherer approved these changes

@misi-bp misi-bp Awaiting requested review from misi-bp

Assignees

@gallotamas gallotamas

Labels
component:ui Issues related to UI/Frontend enhancement New feature or request
Projects
OpenClarity
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gallotamas @chrisgacsal @adamtagscherer